Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CacheFactory and CacheFlush #102

Closed
hzxuzhonghu opened this issue Jan 27, 2024 · 0 comments · Fixed by #103
Closed

Refactor CacheFactory and CacheFlush #102

hzxuzhonghu opened this issue Jan 27, 2024 · 0 comments · Fixed by #103

Comments

@hzxuzhonghu
Copy link
Member

Why is this needed:

type CacheFactory interface {
	StatusFlush(status core_v2.ApiStatus) int
	StatusDelete(status core_v2.ApiStatus)
	StatusReset(old, new core_v2.ApiStatus)
}

CacheFactory is the interface to update and delete xds resources that received from xds control plane.

But currently the cache flushing procedure is quite hard to understand, And there are other caveats:

  1. It does not support delta cache flush, which is useful for delta xds.
  2. the underlying implementor of CacheFactory stores redundant resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant