Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HashName mem leak #155

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

LiZhenCheng9527
Copy link
Collaborator

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixed the bug that when deleting workload and service, the related data in hashName was not deleted.
Which issue(s) this PR fixes:
Fixes #153

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Mar 7, 2024
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thinking a bit more, the HashName is a little obscures, i donot have an idea to help developer not forget to delete the hash map now.

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 7b4b758 into kmesh-net:main Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HashName mem leak
3 participants