automatically mount cgroup2 at kmesh startup #229
Conversation
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -89,6 +89,10 @@ func Start() error { | |||
| return err | |||
| } | |||
|
|
|||
| if err = mountCgroup2(&config); err != nil { | |||
| return err | |||
There was a problem hiding this comment.
AFAIK, cgroup v2 only available in linux kernel v5.8 or above.
Is mouting cgroup v2 a necessary step use kmesh? If not we could just print a warning message and not return error directly, otherwise kmesh could not run on older versions of the kernel.
I guess v5.8 is a pretty high version for production environments.
There was a problem hiding this comment.
https://github.com/kmesh-net/kmesh/blob/main/build/docker/README.md#start_kmeshsh
It is stated that to start kmesh, have to mount cgroupv2.
| @@ -142,3 +146,17 @@ func Stop() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func mountCgroup2(cfg *Config) error { | |||
There was a problem hiding this comment.
I think you need to do some cleanups during pod termination.
Otherwise this should fail.
Take a look at kmesh-start-pre.sh
|
@hzxuzhonghu: GitHub didn't allow me to assign the following users: bitcoffeeiux. Note that only kmesh-net members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
|
||
| if err := syscall.Mount("none", cfg.Cgroup2Path, "cgroup2", 0, ""); err != nil { | ||
| log.Errorf("failed to mount %s: %v", cfg.Cgroup2Path, err) | ||
| return err |
There was a problem hiding this comment.
need clean up resources before return err
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
automatically mount cgroup2 at kmesh startup