Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for false instead of null in ModuleEventRegistration #48

Merged
merged 1 commit into from Aug 10, 2021
Merged

Check for false instead of null in ModuleEventRegistration #48

merged 1 commit into from Aug 10, 2021

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Aug 10, 2021

CalendarLeadsModel::findByLeadEventMail will return false here

$objResult = \Database::getInstance()->prepare($sql)->execute((int)$lid, "eventid", (int)$eid, "email", $mail);
if (!$objResult || $objResult->numRows === 0) {
return false;
}

thus ModuleEventRegistration needs to check for false instead of null (see here.

Fixes #29

@kmielke kmielke merged commit f5de73d into kmielke:master Aug 10, 2021
@kmielke
Copy link
Owner

kmielke commented Aug 10, 2021

Danke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants