Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Bump grunt-lib-phantomjs to ^1.0.0 #157

Closed
wrumsby opened this issue Feb 2, 2016 · 6 comments · Fixed by #158
Closed

Bump grunt-lib-phantomjs to ^1.0.0 #157

wrumsby opened this issue Feb 2, 2016 · 6 comments · Fixed by #158

Comments

@wrumsby
Copy link

wrumsby commented Feb 2, 2016

This version brings in Phantom 2.1 which provides better support for ES5 features, including Function.prototype.bind which wasn't supported in Phantom 1.9.

@kmiyashiro
Copy link
Owner

Cool, this will go into the 1.0 release

@BYK
Copy link
Collaborator

BYK commented Mar 4, 2016

Any news about this or the 1.0 release?

@kmiyashiro
Copy link
Owner

Hey guys, I have a branch for this here: https://github.com/kmiyashiro/grunt-mocha/tree/bump-phantom

Unfortunately, it's breaking the xunit file output test and I don't have time at the moment to investigate more. If anyone wants to investigate the cause, that would be a big help.

@BYK
Copy link
Collaborator

BYK commented Mar 5, 2016

@kmiyashiro - thanks for the update! I'm willing to give a hand with this so I'll checkout the branch and see if I can fix it.

@td-edge
Copy link

td-edge commented Mar 24, 2016

+1

@BYK
Copy link
Collaborator

BYK commented Mar 26, 2016

Okay, I got this working. I had to use latest master instead of the published 1.0.1 version of grunt-phantomjs since it had an important fix that prevented our tests from failing randomly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants