Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RGB_TOG is not powering down RGB #904

Closed
Xoffio opened this issue Oct 21, 2023 · 0 comments · Fixed by #903
Closed

[BUG] RGB_TOG is not powering down RGB #904

Xoffio opened this issue Oct 21, 2023 · 0 comments · Fixed by #903
Labels
bug Something isn't working

Comments

@Xoffio
Copy link

Xoffio commented Oct 21, 2023

Describe the bug
I am using the latest KMK at the moment and it looks like the RGB_TOG got broken at some point.
Any animation like KC.RGB_MODE_RAINBOW or KC.RGB_MODE_KNIGHT works properly.
I can even power down rgb by pressing KC.RGB_VAD multiple times.

if i press RGB_TOG nothing happens. If i have an animation like the knight effect then the animation stops when pressed toggle, and continues once i press the rgb toggle again.

To Reproduce
Tested on a spitted keyboard
Steps to reproduce the behavior:

  • Use the next splitted conf
split = Split(
    split_flip=True,
    split_type=SplitType.UART,
    # split_side=split_side,
    data_pin=keyboard.data_pin,
    use_pio=True,
)
keyboard.modules.append(split)
  • Assign a keyt to KC.RGB_TOG and another one to KC.RGB_MODE_KNIGHT
  • Press the KC.RGB_TOG key

Expected behavior
KC.RGB_TOG should power off the board's rgb. if there is any other animation running, it should turn off the rgb instead of pausing the animation

Note
I think I know why this is happening and i have a peace of code that might fix it.

@Xoffio Xoffio added the bug Something isn't working label Oct 21, 2023
@regicidalplutophage regicidalplutophage linked a pull request Oct 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant