Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

Update rarity filter and notification #44

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update rarity filter and notification #44

wants to merge 6 commits into from

Conversation

junqdu
Copy link

@junqdu junqdu commented Aug 2, 2016

#42

kmoe
kmoe reviewed Aug 2, 2016
View reviewed changes
index.js
} else if (p.rarity.match(/ultra/i)) {
pre = '@channel ';
} else if (p.rarity.match(/ignore/i)) {
logger.log('info', 'Ignoring ' + p.pokemon.name);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be a template string

@kmoe
Copy link
Owner

kmoe commented Aug 2, 2016

Thanks, this is good - just need to fix linting errors

@junqdu
Copy link
Author

junqdu commented Aug 2, 2016

@kmoe Updated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
review done - minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@junqdu @kmoe