-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make around-next only affect the next button #167
Conversation
Before this change, aroundNext was able to change more buttons than just the very next one, provided the next button was released after some other buttons were pressed. For example, suppose we had (defalias nsh (around-next sft)) Then the old behaviour would give T@nsh Ta Tb ==> Ab T@nsh Pa Pb Ra Rb ==> AB while the intended behaviour (and the one that this commit introduces) would be T@nsh Ta Tb ==> Ab T@nsh Pa Pb Ra Rb ==> Ab
Hmmm, I pulled this branch locally and then made some changes and pushed those changes hoping they'd be reflected here, but instead they turned into a branch on the main repo. Not toooo handy with
|
I once tried this in an xmonad pr: I think what you can do is push directly to my branch on my fork of the repository (i.e. directly to https://github.com/slotThe/kmonad/tree/around-next). I did this with
This is completely fine; as long as the issue is fixed that's enough satisfaction for me, no extra github dopamine needed :) |
Oooohh wow, it DID recognize it when I just did the no-github-dopamine version (I couldn't figure out how to push to your copy). Technology, sufficiently advanced, is indistinguishable from magic :-) |
Thank you! |
Quite magical indeed! :)
|
Closes #166
I'm not merging this myself as, while it's technically a bug fix, it
possibly introduces a regression; see the discussion in #166 for all
information.
Before this change,
around-next
was able to change more buttons than justthe very next one, provided the next button was released after some
other buttons were pressed. For example, suppose we had
Then the old behaviour would give
while the intended behaviour (and the one that this commit introduces)
would be