Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_pdfメソッドの分割 #682

Closed
kmuto opened this issue Nov 21, 2016 · 3 comments
Closed

generate_pdfメソッドの分割 #682

kmuto opened this issue Nov 21, 2016 · 3 comments

Comments

@kmuto
Copy link
Owner

kmuto commented Nov 21, 2016

pdfmaker.rb#generate_pdf の分量が大きくてチェッカーに怒られている。
確かに大きいのだが、細分化するにしてもどう細分化するか？

ref #669
@takahashim takahashim mentioned this issue Dec 5, 2016
Merged
@takahashim
Copy link
Collaborator

#686 でどうでしょうか

@kmuto
Copy link
Owner Author

kmuto commented Dec 5, 2016

ありがとうございます！

@takahashim
Copy link
Collaborator

とりあえずマージしますね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@takahashim @kmuto