Ruby 1.8.7 で //list を含む --target=html がコケる #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
対象コードが取り込まれたコミット(今年3月のもの)を眺めてると、コードハイライトに Pygments( http://pygments.org/ ) を使うように変更された模様。 で、関連するかもしれないものは Pygments の issue にあがってました。 しかしこの issue とあまり関係なく、require pygments で Ruby にバンドルされてる Pygments を読み込んでいる部分で、Ruby 1.8.7にバンドルされてる(古い) Pygments には MentosError とか定義されてなくて、結果Ruby側のバインディングも無いんじゃないかなー、という気持ちで見ていました(夏休みReVIEW読書感想文)。 |
|
require pygmentsが失敗した際にrescueでLoadErrorが先に評価されるか、MentosErrorまで先に解釈しようとして詰むのかがRuby 1.8系と1.9系の実装差なのではという推測 |
|
https://gist.github.com/muojp/6227796 つまりこういう話だと思います! |
|
muo変更で1.8.7でテスト通ったし1.9.0でも特になんもなさそうなので追加してpushしてみた！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NameError: uninitialized constant ReVIEW::HTMLUtils::MentosError
/Library/Ruby/Gems/1.8/gems/rake-0.9.2.2/lib/rake/ext/module.rb:36:in
const_missing' /Users/vvakame/Dropbox/work/review/test/../lib/review/htmlutils.rb:50:inhighlight'みたいなエラーが出て、原因がよくわからないのでとりあえず再現だけさせてみました。