Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement imgmath for IDGXML maker #1829

Merged
merged 5 commits into from
Jul 10, 2022
Merged

Conversation

kn1cht
Copy link
Contributor

@kn1cht kn1cht commented Jul 6, 2022

fix #1820

  • lib/review/idgxmlbuilder.rb : texequation()inline_m() に、画像化した数式を出力する動作を追加
  • lib/review/idgxmlmaker.rb : 'review/img_math' を使えるようにコード追加
  • test/test_idgxmlbuilder.rb : 追加した部分についてテストコードを書きました(texequation() キャプションあり・なし、inline_m()

@kn1cht
Copy link
Contributor Author

kn1cht commented Jul 7, 2022

RuboCopに怒られているようなので、確認します(土日になるかもしれません)

@kn1cht
Copy link
Contributor Author

kn1cht commented Jul 9, 2022

テストコードの方がRuboCopのエラーを引き起こしていたため修正しました。

@kmuto
Copy link
Owner

kmuto commented Jul 10, 2022

ありがとうございます!

@kmuto kmuto merged commit caf998d into kmuto:master Jul 10, 2022
@kn1cht
Copy link
Contributor Author

kn1cht commented Jul 10, 2022

ご対応ありがとうございました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting imgmath on IDGXML maker
2 participants