Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint to the latest version 🚀 #22

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Update eslint to the latest version 🚀 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6e5e22
chore(package): update eslint to version 6.1.0
greenkeeper[bot] Jul 21, 2019
b012776
chore(package): update lockfile package-lock.json
greenkeeper[bot] Jul 21, 2019
fed2836
remove hasOwnProperty and for..in loop
kn1cht Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,8 @@ function normalizeForDefaultSort(str) {
'お' : ['お', 'こ', 'そ', 'と', 'の', 'ほ', 'も', 'よ', 'ろ', 'を']
};

for(const key in defaultSortDictionary) {
/* istanbul ignore if */
if(!defaultSortDictionary.hasOwnProperty(key)) { continue; }
str = str.replace(new RegExp(key, 'g'), defaultSortDictionary[key]);
for (const [key, value] of Object.entries(defaultSortDictionary)) {
str = str.replace(new RegExp(key, 'g'), value);
}
str = str.replace(/.[\u30FC\u2010-\u2015\u2212\uFF70-]/g, (match) => {
const firstLetter = match.slice(0, 1);
Expand Down
Loading