You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This regex replace is unnecessary for a default example template. I was confused why the search was not working and ending up in a HTTP authentication required page.
The form didn't look like it had a JS backing. One more suggestion is to remove the name attribute from the search form so that it is more clear. Why need a name if the form submission is actually handled by JS.
The text was updated successfully, but these errors were encountered:
Ah, I think that's there to remove the zwnj characters. True, needn't be in the default search, but ideally, it shouldn't break anything because zwnj is used in so few languages out there anyway. Can you share the examples that broke?
It's a good practice (semantics) to have a name param for inputs, irrespective of whether they're handled by JS or not. Here, if I recall correctly, even if JS is disabled, the form submission should gracefully degrade to GET ?q=xxx and still work.
https://github.com/knadh/dictpress/blob/master/site/static/main.js#L16C1-L17C1
This regex replace is unnecessary for a default example template. I was confused why the search was not working and ending up in a HTTP authentication required page.
The form didn't look like it had a JS backing. One more suggestion is to remove the
name
attribute from the search form so that it is more clear. Why need aname
if the form submission is actually handled by JS.The text was updated successfully, but these errors were encountered: