Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 200 #209

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Fix issue 200 #209

merged 4 commits into from
Mar 20, 2023

Conversation

jxsl13
Copy link
Contributor

@jxsl13 jxsl13 commented Mar 6, 2023 •
edited by rhnvrm

Closes #200

@jxsl13
Copy link
Contributor Author

jxsl13 commented Mar 17, 2023 •
edited

@knadh, can you check this out

@knadh
Copy link
Owner

knadh commented Mar 19, 2023

Sorry, missed this @jxsl13.

Looks good to me. @rhnvrm could you please take a look?

@rhnvrm
Copy link
Collaborator

rhnvrm commented Mar 20, 2023

Looks ok to me. 👍

@knadh knadh merged commit c77dab6 into knadh:master Mar 20, 2023
@knadh
Copy link
Owner

knadh commented Apr 12, 2023 •
edited

@jxsl13 this introduces a new bug (for which there were no tests). Unmarshalling strings to []byte fields no longer work.

Edit: Scratch that. It's in fact happening with mapstructure.StringToSliceHookFunc() in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect assumption in mapstructure library causing panic
4 participants
@jxsl13 @knadh @rhnvrm @john-behm-bertelsmann