Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting AWS SNS notifications (Delivery, Send, ...) as Bounce #1122

Closed
hasahmad opened this issue Dec 29, 2022 · 3 comments
Closed

Accepting AWS SNS notifications (Delivery, Send, ...) as Bounce #1122

hasahmad opened this issue Dec 29, 2022 · 3 comments
Labels
needs-investigation Potential bug. Needs investigation

Comments

@hasahmad
Copy link
Contributor

hasahmad commented Dec 29, 2022

Version:

  • listmonk: v2.3.0
  • OS: Docker Image

Description of the bug and steps to reproduce:
I initially setup in AWS SNS to send all even types (Delivery, Send, ...) and I noticed in listmonk Bounces list that emails with delivery status were also marked as bounce.
I then changed to only send notification for Bounces.

In the code I don't see any checks for eventType, I think we should add check in code to make sure the eventType is Bounce (and maybe also Complaint?)
In sesMail struct, I see notificationType but not eventType where I noticed the Bounce event type.

Payload for notificationType = Delivery

{
  "mail": { ... },
  "delivery": { ... },
  "notificationType": "Delivery"
}

Payload for eventType = Bounce

{
  "mail": { ... },
  "bounce": { ... },
  "eventType": "Bounce"
}
@hasahmad hasahmad added the bug Something isn't working label Dec 29, 2022
@knadh
Copy link
Owner

knadh commented Dec 30, 2022

Will add this check, but non-bounce notifications shouldn't be sent to listmonk. I recollect that when configuring SNS notifications, it's possible to enable bounce-only events.

@kisero
Copy link

kisero commented Jan 6, 2023

In order to improve bounce management it would be great to have an additional column on the schema for bounces that describes the bounce type: Permanent, Transient, Etc.

Discourse has the following settings for bounce type management perhaps this helps for some insipiration. From what I've seen listmonk does this in a slight more limited way.

image

@knadh knadh added needs-investigation Potential bug. Needs investigation and removed bug Something isn't working labels Jan 6, 2023
@knadh
Copy link
Owner

knadh commented Apr 11, 2023

5fc28a7 adds support for per-bounce-type actions.

image

@knadh knadh closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-investigation Potential bug. Needs investigation
Projects
None yet
Development

No branches or pull requests

3 participants