-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom namespaces #12
Conversation
|
Thanks, will review soon! |
I think I would prefer to just export the Is there a reason something like this would not suffice? |
hi, that was my first attempt as well, the end result of that if i read it correctly and from what i can remember was that the custom prefixes were not actually written to file (it checks if namespace contains first, and only writes if it is not found, which of course it is because we set it previously) |
but of course, the type can be ommited and you can just use Namespaces as cNS and keep the ns. i would really really like to somehow keep the flag related to only namespacing if a custom namespace is found, it just makes everything better :D (in our case) do you want me to modify the pull request as i described and per your instructions? |
hi @boutros , i modified it some more, hopefully it is more along the lines of what you want now thank you again for looking into this |
Thanks! I'm fine with a flag which turns off auto-generated namespaces. |
ok, i ll try :d |
i think i sorted it, please take a look, |
Great, thanks! |
first part of #10