Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FieldWithoutContent and FieldWithContent for each of the supported types #25

Closed
linxcat opened this issue Mar 13, 2015 · 1 comment

Comments

@linxcat
Copy link
Collaborator

linxcat commented Mar 13, 2015

The String, Image, Video, Audio, RadioButton, CheckBox, and ListItem types must each get their own implementation of the two field abstractions

@williamvanderkamp
Copy link
Collaborator

I think for the ones with several options, we actually need all the options together to compose a single field.

i.e. RadioGroup, Checkboxes, List, instead of RadioButton, Checkbox, ListItem. (Though we do need a 'single option' case 'Checkbox' that is probably different from 'Checkboxes'.)

I will probably create a ListField interface that all of these 'several options' fields will implement.

FieldWithoutContent also needs a Serializable 'params' field so that the options and/or units can be passed with the spec. Each implementation of FieldWIthoutContent would know how to de/serialize its own params.

@linxcat linxcat closed this as completed Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants