Php code cleanup #119
Merged
Php code cleanup #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greylabel
commented
Nov 13, 2023
| @@ -1,8 +1,10 @@ | |||
| <?php | |||
|
|
|||
| // declare(strict_types=1); | |||
There was a problem hiding this comment.
Will enable this for all files in an upcoming PR.
| use Twig\Environment; | ||
| use Twig\TwigFunction; | ||
|
|
||
| function addCustomExtension(Environment &$env, $config) { | ||
| $env->addFunction(new TwigFunction('customTwigFunctionThatSaysWorld', fn() => 'Custom World')); | ||
| function addCustomExtension(Environment &$twigEnvironment, $config): void { |
There was a problem hiding this comment.
Changes in this PR make use of new arrow function syntax and typing.
|
|
||
| function __construct(array $config) { | ||
| $this->config = $config; | ||
| function __construct(public array $config) { |
There was a problem hiding this comment.
$config makes use of new constructor promotion feature.
| @@ -34,7 +36,7 @@ | |||
| } | |||
|
|
|||
| try { | |||
| $config = json_decode($configString, true); | |||
| $config = json_decode($configString, true, 512, JSON_THROW_ON_ERROR); | |||
There was a problem hiding this comment.
New JSON_THROW_ON_ERROR is a better error experience with json_decode and json_encode
EvanLovely
approved these changes
Nov 13, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of a couple PRs related to cleanup/modernizing before bumping to twig 3, and then update all the JS packages and implementation.