Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with earlier versions of minitest #24

Closed
dkniffin opened this issue Oct 15, 2015 · 3 comments
Closed

Incompatibility with earlier versions of minitest #24

dkniffin opened this issue Oct 15, 2015 · 3 comments

Comments

@dkniffin
Copy link
Contributor

In earlier version of minitest, Minitest.after_run isn't available. Instead, the method for doing that was Minitest::Unit.after_tests. I will submit a PR soon with a fix for this.
@dkniffin
Copy link
Contributor Author

Is there a good way to test this?

@ArturT
Copy link
Member

ArturT commented Oct 15, 2015

Right now I don't have a good idea how to test this across two minitest versions.

In rspec adapter I did similar workaround https://github.com/ArturT/knapsack/blob/master/lib/knapsack/adapters/rspec_adapter.rb#L10,L15

Please create PR then we will figure out something.

Thanks!

@ArturT
Copy link
Member

ArturT commented Oct 31, 2015

Fixed in the PR #26

@ArturT ArturT closed this as completed Oct 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArturT @dkniffin