Make knapsack backwards compatible with earlier version of minitest#26
Merged
ArturT merged 4 commits intoKnapsackPro:masterfrom Oct 27, 2015
Merged
Make knapsack backwards compatible with earlier version of minitest#26ArturT merged 4 commits intoKnapsackPro:masterfrom
ArturT merged 4 commits intoKnapsackPro:masterfrom
Conversation
after_run was implemented in a newer version of minitest
- Added support for earlier versions of minitest that use after_tests instead of after_run - Slightly better way of finding the file containing the test
Member
There was a problem hiding this comment.
You experienced problem with this in case when you had helper methods without test_ in name?
Contributor
Author
There was a problem hiding this comment.
Yea, I forget the issue I ran into, but this fixed it :/
ArturT
added a commit
that referenced
this pull request
Oct 27, 2015
Make knapsack backwards compatible with earlier version of minitest
Member
|
@dkniffin Thanks for awesome work! |
ArturT
added a commit
to KnapsackPro/knapsack_pro-ruby
that referenced
this pull request
Oct 27, 2015
This was referenced Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.