Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Knapsack with shoulda_context #32

Closed
nikz opened this issue Mar 9, 2016 · 3 comments
Closed

Using Knapsack with shoulda_context #32

nikz opened this issue Mar 9, 2016 · 3 comments

Comments

@nikz
Copy link

nikz commented Mar 9, 2016

Hiya!

Knapsack looks great, thanks!

On small problem - we're using the shoulda-context gem, and it seems like this is interfering with the test timing reporter. The JSON that's being generated is just:

{
  "/home/travis/.rvm/gems/ruby-2.1.4/gems/shoulda-context-1.2.1/lib/shoulda/context/context.rb": 183.92807483673096
}

Is there anything we can do to fix this up? Or is that what we're expecting?

Thanks!

@nikz nikz changed the title Using Knapsack with should_context Using Knapsack with shoulda_context Mar 9, 2016
@ArturT
Copy link
Member

ArturT commented Mar 9, 2016

Hi,

It looks like we need a fix to handle the case when shoulda-context gem is available.
Could you create a pull request for that? Here is the adapter for minitest and the method test_path responsible for determining a test file path. Please take a look:
https://github.com/ArturT/knapsack/blob/master/lib/knapsack/adapters/minitest_adapter.rb#L49

@ArturT
Copy link
Member

ArturT commented Oct 7, 2016

NOTE:
Here is PR fix for shoulda-context. thoughtbot/shoulda-context#51
Once merged then we can close this issue.

@ArturT ArturT closed this as completed Nov 6, 2016
@ArturT
Copy link
Member

ArturT commented Nov 6, 2016

shoulda-context release 1.2.2 solves problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants