Uses class_eval when dynamically creating tests so that we can pass in source location #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2016 17:25
Uses class eval to not lose context
lib/shoulda/context/context.rb
Outdated
| source_location = should[:block].source_location | ||
| context = self | ||
| test_unit_class.send(:define_method, test_name) do | ||
| test_unit_class.class_eval <<-end_eval, source_location[0], source_location[1] |
There was a problem hiding this comment.
Line is too long. [88/80]
Trailing whitespace detected.
|
@alexpjohnson @jferris any chance for this to be merged in? |
Author
|
I'd be happy to, but I don't have write access. We would need someone from thoughtbot to take a look. |
Author
|
@travisjeffery Would you mind taking a look at this? |
|
We would also love this one to be merged, how can we help? |
Collaborator
|
Thanks for bringing this up again! Just released 1.2.2 for this |
This was referenced Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #50