Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update owner files #2

Closed
wants to merge 1 commit into from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented May 21, 2024

Changes

/kind

Fixes #

Release Note


Docs

Copy link

knative-prow bot commented May 21, 2024

@skonto: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested a review from izabelacg May 21, 2024 11:07
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2024
@skonto
Copy link
Contributor Author

skonto commented May 21, 2024

/hold to clean up commits

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@skonto
Copy link
Contributor Author

skonto commented May 21, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@@ -5,6 +5,7 @@ approvers:
- technical-oversight-committee
- serving-wg-leads
- serving-writers
- autoscaler-keda-approvers

reviewers:
- serving-reviewers
Copy link
Contributor Author

@skonto skonto May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could replace this with autoscaler-keda-approvers to avoid noise (other extension repos do that) but also it might be useful so others are invited to review stuff.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
Copy link

knative-prow bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Contributor Author

skonto commented May 21, 2024

/easycla

2 similar comments
@DerrickLFX
Copy link

/easycla

@skonto
Copy link
Contributor Author

skonto commented May 24, 2024

/easycla

@ReToCode
Copy link
Member

/test ?

Copy link

knative-prow bot commented May 28, 2024

@ReToCode: The following commands are available to trigger required jobs:

  • /test build-tests
  • /test integration-tests
  • /test unit-tests

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ReToCode
Copy link
Member

/override "build-tests"

/override "integration-tests"

/override "unit-tests"

Copy link

knative-prow bot commented May 28, 2024

@ReToCode: ReToCode unauthorized: /override is restricted to Repo administrators.

In response to this:

/override "build-tests"

/override "integration-tests"

/override "unit-tests"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto skonto closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants