Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

Remove incorrect info from readme #119

Merged
merged 3 commits into from
May 24, 2022
Merged

Remove incorrect info from readme #119

merged 3 commits into from
May 24, 2022

Conversation

psschwei
Copy link
Contributor

Signed-off-by: Paul S. Schweigert paulschw@us.ibm.com

/assign @nader-ziada

@psschwei
remove incorrect info from readme
23c0423 
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com>
@knative-prow
Copy link

knative-prow bot commented May 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2022
nader-ziada
nader-ziada reviewed May 24, 2022
View reviewed changes
README.md Outdated
@@ -38,8 +38,6 @@ cd container-freezer
ko apply -f config/
```

This will install the daemon for the container-freezer, the required permissions, and a service for the daemon. By default, the service has the endpoint http://freeze-service.knative-serving.svc.cluster.local:9696, which we'll need in the next step.

Note: in the future, it will also be possible to install via `kubectl apply -f container-freezer.yaml`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to remove this line as well since we are not there yet?

@psschwei
more purging
6f2ccf5 
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com>
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022 •
edited
Loading

Codecov Report

Merging #119 (6f2ccf5) into main (d23f976) will not change coverage.
The diff coverage is n/a.

❗ Current head 6f2ccf5 differs from pull request most recent head 1bb3d81. Consider uploading reports for the commit 1bb3d81 to get more accurate results

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   29.13%   29.13%           
=======================================
  Files           2        2           
  Lines         127      127           
=======================================
  Hits           37       37           
  Misses         83       83           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23f976...1bb3d81. Read the comment docs.

@nader-ziada
Copy link

the lint failed with trailing whitespace, but otherwise lgtm

@psschwei
whitespace :shakes-fist:
1bb3d81 
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com>
@nader-ziada
Copy link

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@nader-ziada
Copy link

nice commit message :D

@knative-prow knative-prow bot merged commit 89ada44 into knative-extensions:main May 24, 2022
@psschwei psschwei deleted the fix-readme branch August 10, 2022 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nader-ziada nader-ziada nader-ziada left review comments

Assignees

@nader-ziada nader-ziada

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@psschwei @nader-ziada