-
Notifications
You must be signed in to change notification settings - Fork 20
Add performance test #156
Add performance test #156
Conversation
Hi @jwcesign. Thanks for your PR. I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
565d7e1
to
e8b5c14
Compare
20722b8
to
cca74f0
Compare
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 67.35% 67.35%
=======================================
Files 5 5
Lines 193 193
=======================================
Hits 130 130
Misses 44 44
Partials 19 19 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/test pull-knative-sandbox-container-freezer-build-tests |
@jwcesign: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @psschwei give one |
So for the useage like: /test pull-knative-sandbox-container-freezer-performance-tests-hey First, I should set here test-infra Than add a shell file in this PR. |
@jwcesign: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-knative-sandbox-container-freezer-build-tests |
@jwcesign: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8c13182
to
16409e9
Compare
cc @nader-ziada @psschwei , when you are available, please check it. It works on my local cluster when comment |
16409e9
to
00fd7b9
Compare
# Copyright 2022 The Knative Authors | ||
#!/usr/bin/env bash | ||
|
||
# Copyright 2018 The Knative Authors | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy from serving repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the dates in both scripts as 2022 since that's when they were added to this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -0,0 +1,132 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy from serving repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits:
- when I pulled the PR, none of the scripts were marked executable, I think they'll need a
chmod +x
in order to run via prow - test currently requires istio in order to generate results, as
get_gateway_ip()
checks the istio namespace - there's a lot of bits in the copied over tests scripts that we aren't using and could probably be cut
00fd7b9
to
9f2d6b1
Compare
9f2d6b1
to
265af8e
Compare
5c997a9
to
413ce6b
Compare
I use |
Signed-off-by: jiang wei <jwcesign@gmail.com>
413ce6b
to
37a14f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
We might want to add a README for the performance test with a note on how to use an alternative ingress, but can do that in a separate PR.
Thanks for adding this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwcesign, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix #151