Include Channel’s ExternalName services in Istio mesh #16

pierDipi · 2023-04-11T18:34:54Z

Implementation for https://docs.google.com/document/d/1Y9BukjzUxfl920KltVtH4L5gta0pHOt5NEsLqdgZNY4/edit

For review I'd recommend checking out the PR locally

To enabled the integration you need to specify in config-features an istio flag:

apiVersion: v1
kind: ConfigMap
metadata:
  name: config-features
  namespace: knative-eventing
data:
  istio: "enabled"

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2023-04-17T12:23:52Z

Waiting for knative-extensions/eventing-kafka-broker#3045

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2023-04-17T16:35:56Z

Waiting for knative/eventing#6862

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2023-05-04T09:37:36Z

https://github.com/pierDipi/eventing-istio/blob/channel-reconciler/pkg/reconciler/service/service.go#L60-L64

The comment here is slightly different than the log. Wanna adjust?

Done

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

matzew

/lgtm
/approve

knative-prow · 2023-05-04T10:14:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [matzew,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

creydr

LGTM from my side. Leaving it open for others to review too

pierDipi · 2023-05-04T11:52:31Z

@creydr do you have any comments?

pierDipi · 2023-05-04T11:52:43Z

lol :)

pierDipi · 2023-05-04T11:52:52Z

/unhold

pierDipi · 2023-05-04T15:47:37Z

/override ?

knative-prow · 2023-05-04T15:47:41Z

@pierDipi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

?

Only the following failed contexts/checkruns were expected:

EasyCLA
build-tests_eventing-istio_main
integration-tests_eventing-istio_main
style / Golang / Boilerplate Check (go)
style / suggester / github_actions
style / suggester / shell
tide
unit-tests_eventing-istio_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi · 2023-05-04T15:48:02Z

/override style / Golang / Boilerplate Check (go)

knative-prow · 2023-05-04T15:48:06Z

@pierDipi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

(go)
/
Boilerplate
Check
Golang
style

Only the following failed contexts/checkruns were expected:

EasyCLA
build-tests_eventing-istio_main
integration-tests_eventing-istio_main
style / Golang / Boilerplate Check (go)
style / suggester / github_actions
style / suggester / shell
tide
unit-tests_eventing-istio_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override style / Golang / Boilerplate Check (go)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi · 2023-05-04T15:48:08Z

/override style / suggester / shell

knative-prow · 2023-05-04T15:48:12Z

@pierDipi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

/
shell
style
suggester

Only the following failed contexts/checkruns were expected:

EasyCLA
build-tests_eventing-istio_main
integration-tests_eventing-istio_main
style / Golang / Boilerplate Check (go)
style / suggester / github_actions
style / suggester / shell
tide
unit-tests_eventing-istio_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override style / suggester / shell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi · 2023-05-04T15:48:33Z

/override style

knative-prow · 2023-05-04T15:48:36Z

@pierDipi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

style

Only the following failed contexts/checkruns were expected:

EasyCLA
build-tests_eventing-istio_main
integration-tests_eventing-istio_main
style / Golang / Boilerplate Check (go)
style / suggester / github_actions
style / suggester / shell
tide
unit-tests_eventing-istio_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override style

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi · 2023-05-04T15:48:38Z

/override shell

knative-prow · 2023-05-04T15:48:41Z

@pierDipi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

shell

Only the following failed contexts/checkruns were expected:

EasyCLA
build-tests_eventing-istio_main
integration-tests_eventing-istio_main
style / Golang / Boilerplate Check (go)
style / suggester / github_actions
style / suggester / shell
tide
unit-tests_eventing-istio_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override shell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi · 2023-05-04T15:49:06Z

/override "style / suggester / shell"

knative-prow · 2023-05-04T15:49:11Z

@pierDipi: Overrode contexts on behalf of pierDipi: style / suggester / shell

In response to this:

/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi · 2023-05-04T15:49:28Z

/override "style / Golang / Boilerplate Check (go)"

knative-prow · 2023-05-04T15:50:06Z

@pierDipi: Overrode contexts on behalf of pierDipi: style / Golang / Boilerplate Check (go)

In response to this:

/override "style / Golang / Boilerplate Check (go)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ions#16) * Include Channel’s ExternalName services in Istio mesh Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Run hack/update-codegen.sh Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Format Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Test and release setup Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Upgrade dependencies Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Add IMC and KafkaChannel tests Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Format and fix tests Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Upgrade dependencies Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Add access to configmaps Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Add config-features for testing and install script for dev Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Debug logging for istio enabled Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix controller Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Include knative-extensions/eventing-kafka-broker#3045 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Use core zap Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix unit tests Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Add unit tests Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Upgrade dependencies and artifacts Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix host name Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Upgrade dependencies Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Upgrade dependencies Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Upgrade deps and artifacts Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Add full config-features Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix boilerplate check Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Improve log message Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * More boilerplate check fixes Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Update codegen Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

…tive-extensions#16) Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi added 4 commits April 11, 2023 20:17

Include Channel’s ExternalName services in Istio mesh

239b153

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Run hack/update-codegen.sh

c80c32a

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Format

458f5d8

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Test and release setup

0fe8524

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi added 7 commits April 11, 2023 20:44

Upgrade dependencies

593f6ab

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Add IMC and KafkaChannel tests

7e20d97

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Format and fix tests

63361ee

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Upgrade dependencies

386f46f

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Add access to configmaps

2943bf9

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Add config-features for testing and install script for dev

f2e0844

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Debug logging for istio enabled

90bfce1

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi added 4 commits April 17, 2023 14:39

Fix controller

b1aae2b

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Include knative-extensions/eventing-kafka-broker#3045

52ea104

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Use core zap

8d871e3

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Fix unit tests

ada494e

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi added 3 commits April 19, 2023 12:43

Add unit tests

5bbfa6e

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Upgrade dependencies and artifacts

0934cbe

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Fix host name

2ee2825

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi force-pushed the channel-reconciler branch from 8fcb8ca to 2ee2825 Compare May 2, 2023 09:36

knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 2, 2023

pierDipi added 2 commits May 2, 2023 12:43

Upgrade dependencies

7a4978a

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Merge branch 'main' into channel-reconciler

c7251bc

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2023

pierDipi mentioned this pull request May 2, 2023

Fix ugprade dependencies/submodules script #12

Merged

Improve log message

a0538b9

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 4, 2023

pierDipi added 2 commits May 4, 2023 11:42

More boilerplate check fixes

eefe714

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Update codegen

a7dfa7c

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

matzew approved these changes May 4, 2023

View reviewed changes

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023

creydr reviewed May 4, 2023

View reviewed changes

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023

knative-prow bot merged commit ac9fa53 into knative-extensions:main May 4, 2023

creydr pushed a commit to creydr/knative-eventing-istio that referenced this pull request Aug 2, 2023

Use target/midstream branch instead of upstream tag to infer tag (kna…

7d3a3e0

…tive-extensions#16) Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include Channel’s ExternalName services in Istio mesh #16

Include Channel’s ExternalName services in Istio mesh #16

pierDipi commented Apr 11, 2023 •

edited

Loading

pierDipi commented Apr 17, 2023

pierDipi commented Apr 17, 2023

pierDipi commented May 4, 2023

matzew left a comment

knative-prow bot commented May 4, 2023

creydr left a comment

pierDipi commented May 4, 2023

pierDipi commented May 4, 2023

pierDipi commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

Include Channel’s ExternalName services in Istio mesh #16

Include Channel’s ExternalName services in Istio mesh #16

Conversation

pierDipi commented Apr 11, 2023 • edited Loading

pierDipi commented Apr 17, 2023

pierDipi commented Apr 17, 2023

pierDipi commented May 4, 2023

matzew left a comment

Choose a reason for hiding this comment

knative-prow bot commented May 4, 2023

creydr left a comment

Choose a reason for hiding this comment

pierDipi commented May 4, 2023

pierDipi commented May 4, 2023

pierDipi commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented May 4, 2023

knative-prow bot commented May 4, 2023

pierDipi commented Apr 11, 2023 •

edited

Loading