Do not add a finalizer on triggers without a broker (#880)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-extensions · May 24, 2021 · ef24ea0 · ef24ea0
1 parent 3c96727
commit ef24ea0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/control-plane/pkg/reconciler/trigger/controller.go b/control-plane/pkg/reconciler/trigger/controller.go
@@ -125,7 +125,7 @@ func filterTriggers(lister eventinglisters.BrokerLister) func(interface{}) bool
 
 		broker, err := lister.Brokers(trigger.Namespace).Get(trigger.Spec.Broker)
 		if err != nil {
-			return true // TODO decide what to do on NotFound/Found
+			return false
 		}
 
 		value, ok := broker.GetAnnotations()[apiseventing.BrokerClassKey]

diff --git a/control-plane/pkg/reconciler/trigger/controller_test.go b/control-plane/pkg/reconciler/trigger/controller_test.go
@@ -54,5 +54,5 @@ func TestFilterTriggers(t *testing.T) {
 		},
 	})
 
-	assert.True(t, pass)
+	assert.False(t, pass)
 }