Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable unnecessary metrics #2147

Merged
merged 1 commit into from May 3, 2022
Merged

Disable unnecessary metrics #2147

merged 1 commit into from May 3, 2022

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented May 3, 2022

Vert.x's client, server and verticles metrics adds a lot of
allocations and their metrics exposed add little value in a
kubernetes environment or in our case.

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

Fixes #

Proposed Changes

  • Disable unnecessary metrics

Release Note

`vertx_*` metrics have been removed since they were causing unnecessary allocations.

@pierDipi
Disable unnecessary metrics
464687f 
Vert.x's client, server and verticles metrics adds a lot of
allocations and their metrics exposed add little value in a
kubernetes environment or our case.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added area/data-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2022
@pierDipi
Copy link
Member Author

pierDipi commented May 3, 2022

/cc @matzew @aavarghese

@knative-prow knative-prow bot requested review from aavarghese and matzew May 3, 2022 17:57
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@pierDipi pierDipi mentioned this pull request May 3, 2022
Merged
@pierDipi
Copy link
Member Author

pierDipi commented May 3, 2022

/test unit-tests_eventing-kafka-broker_main

@matzew
Copy link
Contributor

matzew commented May 3, 2022

Vert.x's client, server and verticles metrics adds a lot of
allocations and their metrics exposed add little value in a
kubernetes environment or in our case.

+1 on doing this!

@codecov
Copy link

codecov bot commented May 3, 2022 •
edited

Codecov Report

Merging #2147 (464687f) into main (47eb7f4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2147      +/-   ##
============================================
+ Coverage     66.54%   66.57%   +0.02%     
- Complexity      677      678       +1     
============================================
  Files           142      142              
  Lines          9141     9146       +5     
  Branches        196      196              
============================================
+ Hits           6083     6089       +6     
  Misses         2652     2652              
+ Partials        406      405       -1
Flag Coverage Δ
java-unittests 82.66% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ve/eventing/kafka/broker/core/metrics/Metrics.java 89.04% <100.00%> (+0.80%) ⬆️
...a/broker/dispatcher/impl/RecordDispatcherImpl.java 90.44% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47eb7f4...464687f. Read the comment docs.

matzew
matzew reviewed May 3, 2022
View reviewed changes
data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/metrics/Metrics.java
Comment on lines +119 to 126
.addDisabledMetricsCategory(MetricsDomain.HTTP_CLIENT)
.addDisabledMetricsCategory(MetricsDomain.HTTP_SERVER)
.addDisabledMetricsCategory(MetricsDomain.VERTICLES)
.addDisabledMetricsCategory(MetricsDomain.NET_CLIENT)
.addDisabledMetricsCategory(MetricsDomain.NET_SERVER)
.addDisabledMetricsCategory(MetricsDomain.EVENT_BUS)
.addDisabledMetricsCategory(MetricsDomain.DATAGRAM_SOCKET)
// NAMED_POOL allocates a lot, so disable it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

we could factor those into its own method for a more compact execution - looks like the more we add, the more verbose this gets.

Just a comment 😅

matzew
matzew approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
@knative-prow
Copy link

knative-prow bot commented May 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1e51629 into knative-extensions:main May 3, 2022
@matzew
Copy link
Contributor

matzew commented May 4, 2022

@pierDipi what about doing backports?

@pierDipi
Copy link
Member Author

pierDipi commented May 4, 2022

/cherry-pick release-1.4

@pierDipi
Copy link
Member Author

pierDipi commented May 4, 2022

/cherry-pick release-1.3

@pierDipi
Copy link
Member Author

pierDipi commented May 4, 2022

/cherry-pick release-1.2

@knative-prow-robot knative-prow-robot mentioned this pull request May 4, 2022
Merged
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #2154

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request May 4, 2022
Merged
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #2155

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request May 4, 2022
Merged
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #2156

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@aavarghese aavarghese Awaiting requested review from aavarghese

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierDipi @matzew @knative-prow-robot