Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable unnecessary metrics #2147

Merged
merged 1 commit into from May 3, 2022
Merged

Disable unnecessary metrics #2147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/metrics/Metrics.java
View file
Open in desktop
Expand Up @@ -116,6 +116,11 @@ public static MetricsOptions getOptions(final BaseEnv metricsConfigs) {
final var registry = new PrometheusMeterRegistry(PrometheusConfig.DEFAULT);
return new MicrometerMetricsOptions()
.setEnabled(true)
.addDisabledMetricsCategory(MetricsDomain.HTTP_CLIENT)
.addDisabledMetricsCategory(MetricsDomain.HTTP_SERVER)
.addDisabledMetricsCategory(MetricsDomain.VERTICLES)
.addDisabledMetricsCategory(MetricsDomain.NET_CLIENT)
.addDisabledMetricsCategory(MetricsDomain.NET_SERVER)
.addDisabledMetricsCategory(MetricsDomain.EVENT_BUS)
.addDisabledMetricsCategory(MetricsDomain.DATAGRAM_SOCKET)
// NAMED_POOL allocates a lot, so disable it.
Comment on lines +119 to 126
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

we could factor those into its own method for a more compact execution - looks like the more we add, the more verbose this gets.

Just a comment 😅

Expand Down