Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit tests] reconciliation removal of keda objects #3701

Closed
converge opened this issue Feb 14, 2024 · 3 comments
Closed

[unit tests] reconciliation removal of keda objects #3701

converge opened this issue Feb 14, 2024 · 3 comments
Assignees
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@converge
Copy link
Member

Problem
this PR #3676 is missing unit tests. I would like to create them on a separated PR.

@Cali0707
Copy link
Member

Cali0707 commented Mar 1, 2024

/triage accepted
/assign @converge

Thanks for volunteering to work on this on slack @converge , feel free to unassign if you change your mind!

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Mar 1, 2024
@Cali0707
Copy link
Member

I believe this is resolved now, feel free to re-open if for some reason it isn't
/close

@knative-prow knative-prow bot closed this as completed Jun 11, 2024
Copy link

knative-prow bot commented Jun 11, 2024

@Cali0707: Closing this issue.

In response to this:

I believe this is resolved now, feel free to re-open if for some reason it isn't
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

2 participants