Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DeadLetterSinkURI in the Broker and Trigger status #1349

Merged
merged 2 commits into from Oct 25, 2021
Merged

Set DeadLetterSinkURI in the Broker and Trigger status #1349

merged 2 commits into from Oct 25, 2021

Conversation

pierDipi
Copy link
Member

Fixes #1334

Proposed Changes

  • Set DeadLetterSinkURI in Broker, Trigger and Channel status
  • Upgrade to latest dependencies

Release Note

Set `status.deadLetterSinkUri` of `Broker` and `Trigger` to the resolved URI of `spec.delivery.deadLetterSink`.

Docs

None

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 19, 2021
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/control-plane approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021 •
edited

Codecov Report

Merging #1349 (cd87fd7) into main (5281ebc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1349      +/-   ##
============================================
+ Coverage     75.82%   75.85%   +0.03%     
  Complexity      540      540              
============================================
  Files            95       95              
  Lines          3375     3380       +5     
  Branches        154      154              
============================================
+ Hits           2559     2564       +5     
  Misses          628      628              
  Partials        188      188
Flag Coverage Δ
java-unittests 81.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/core/config/egress.go 100.00% <100.00%> (ø)
control-plane/pkg/reconciler/broker/broker.go 72.19% <100.00%> (+0.14%) ⬆️
control-plane/pkg/reconciler/trigger/trigger.go 70.83% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5281ebc...cd87fd7. Read the comment docs.

@pierDipi
Copy link
Member Author

This needs the new Broker and Trigger CRDs in a PR like #1346
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2021
@pierDipi pierDipi changed the title Set DeadLetterSinkURI in the Broker and Trigger status [WIP] Set DeadLetterSinkURI in the Broker and Trigger status Oct 19, 2021
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2021
@matzew
Copy link
Contributor

matzew commented Oct 19, 2021

@pierDipi what PR did change the CRDs of broker/trigger?

@pierDipi
Copy link
Member Author

PRs with a title like "[Automated] Update eventing-kafka-broker-eventing nightly" (example #1346)

knative-automation and others added 2 commits October 20, 2021 20:44
@knative-automation @pierDipi
upgrade to latest dependencies
2ba05a5 
bumping knative.dev/eventing a6a819d...a34aaa0:
  > a34aaa0 💄 It's a deadLetterSink that we define. It is not a queue (# 5824)
  > eb87183 fixing COC doc (# 5774)
  > d98ae8c Fix broker status dlquri (# 5793)
  > 7ab2c01 upgrade to latest dependencies (# 5822)
  > 5f69768 upgrade to latest dependencies (# 5817)
bumping knative.dev/hack 815cd31...47ac3b0:
  > 47ac3b0 Split build tags that are in a comma separated list (# 83)
  > 8687668 [# 50] Add error message when Bash < 4 (# 79)
  > 8d79600 Fixes # 81 (# 82)
  > 51582ce fix misspelling functionallity -> functionality (# 78)
  > 675e1fd Correctly specify the user when creating clusterrolebinding for kind (# 80)
bumping knative.dev/pkg fa2f8f1...a34efd6:
  > a34efd6 upgrade to latest dependencies (# 2317)
  > ecdde77 Update actions (# 2316)
  > 3463dd7 upgrade to latest dependencies (# 2315)
  > a5bb759 upgrade to latest dependencies (# 2314)
  > e61a20d Update actions (# 2313)
  > 0e24b49 Format go code (# 2312)
bumping knative.dev/reconciler-test 45904ca...816dbd1:
  > 816dbd1 Update actions (# 237)

Signed-off-by: Knative Automation <automation@knative.team>
@pierDipi
Set DeadLetterSinkURI in Broker, Trigger and Channel status
cd87fd7 
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@pierDipi pierDipi force-pushed the KNATIVE-DLS-broker-trigger-channel branch from 067a605 to cd87fd7 Compare October 20, 2021 18:44
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/reconciler/broker/broker.go 85.2% 85.3% 0.1
control-plane/pkg/reconciler/trigger/trigger.go 84.6% 84.7% 0.1

@pierDipi pierDipi changed the title [WIP] Set DeadLetterSinkURI in the Broker and Trigger status Set DeadLetterSinkURI in the Broker and Trigger status Oct 20, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2021
@pierDipi
Copy link
Member Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2021
@pierDipi pierDipi mentioned this pull request Oct 25, 2021
Closed
aliok
aliok approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 99ef265 into knative-extensions:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok aliok approved these changes

@matzew matzew Awaiting requested review from matzew

@devguyio devguyio Awaiting requested review from devguyio

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pierDipi @matzew @knative-metrics-robot @knative-prow-robot @aliok @knative-automation