Add KafkaSource to released YAMLs #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
knative-prow-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## main #1415 +/- ##
=========================================
Coverage 76.24% 76.24%
Complexity 584 584
=========================================
Files 98 98
Lines 3658 3658
Branches 166 166
=========================================
Hits 2789 2789
Misses 653 653
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
matzew
reviewed
Nov 5, 2021
| @@ -23,6 +23,7 @@ source $(dirname $0)/data-plane.sh | |||
| source $(dirname $0)/control-plane.sh | |||
|
|
|||
| export EVENTING_KAFKA_CONTROL_PLANE_ARTIFACT="eventing-kafka-controller.yaml" | |||
| export EVENTING_KAFKA_SOURCE_ARTIFACT="eventing-kafka-source.yaml" | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aliok
pushed a commit
to aliok/eventing-kafka-broker
that referenced
this pull request
Nov 5, 2021
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
Proposed Changes
Release Note
Docs