New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run channel Rekt tests #1825
Run channel Rekt tests #1825
Conversation
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## main #1825 +/- ##
============================================
- Coverage 66.53% 66.44% -0.09%
Complexity 614 614
============================================
Files 134 134
Lines 5687 5687
Branches 178 178
============================================
- Hits 3784 3779 -5
- Misses 1600 1604 +4
- Partials 303 304 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/test pull-knative-sandbox-eventing-kafka-broker-upgrade-tests |
93d3f31
to
c29af95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Possible fix: #1811 /test pull-knative-sandbox-eventing-kafka-broker-reconciler-tests |
If this PR merges w/o that fix, let's merge. |
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests |
Fixes #
Proposed Changes
cloudevents
tag was required to run Rekt tests for KafkaChannel but was forgottenRelease Note
Docs