Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run channel Rekt tests #1825

Conversation

aliok
Copy link
Member

@aliok aliok commented Jan 28, 2022

Fixes #

Proposed Changes

  • Run channel Rekt tests
  • cloudevents tag was required to run Rekt tests for KafkaChannel but was forgotten
  • Depends on Revert channel parts of #1720 #1824. It is to revert the breakage merged unnoticed because of the conformance tests not running.

Release Note

:gift: KafkaChannel becomes conformant with spec. Conformance tests are now run with every code change.

Docs

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/control-plane area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2022
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/reconciler/channel/channel.go 69.8% 69.8% -0.0

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #1825 (c29af95) into main (862e933) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1825      +/-   ##
============================================
- Coverage     66.53%   66.44%   -0.09%     
  Complexity      614      614              
============================================
  Files           134      134              
  Lines          5687     5687              
  Branches        178      178              
============================================
- Hits           3784     3779       -5     
- Misses         1600     1604       +4     
- Partials        303      304       +1     
Flag Coverage Δ
java-unittests 82.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/prober/prober.go 60.00% <0.00%> (-15.00%) ⬇️
control-plane/pkg/prober/cache.go 95.23% <0.00%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862e933...c29af95. Read the comment docs.

@pierDipi
Copy link
Member

pierDipi commented Feb 1, 2022

/test pull-knative-sandbox-eventing-kafka-broker-upgrade-tests

@aliok aliok force-pushed the 2022-01-28-proper-e2e-testing-for-channel branch from 93d3f31 to c29af95 Compare February 1, 2022 14:39
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2022
@aliok aliok changed the title [WIP] Run channel Rekt tests Run channel Rekt tests Feb 1, 2022
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2022
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

pierDipi commented Feb 1, 2022

=== RUN   TestBrokerDeletedRecreated/broker_deleted_and_recreated/Assert/[Stable/MUST]test_broker_after_deletion
=== CONT  TestBrokerDeletedRecreated/broker_deleted_and_recreated/Assert/[Stable/MUST]test_broker_after_deletion
    event_info_store.go:72: Store added to the EventListener, which has already seen 15 events
2022/02/01 15:20:53 new files in /tmp/processed_yaml811421402
I0201 15:20:53.003383   50761 manifest.go:62] Reading YAML filepath: /tmp/processed_yaml811421402 recursive: false
2022/02/01 15:20:53 Created:
2022/02/01 15:20:53 {Subscription test-wxjggsyx subscription-0008-umgaqrpc  messaging.knative.dev/v1  }
=== CONT  TestBrokerDeletedRecreated/broker_deleted_and_recreated/Assert/[Stable/MUST]test_broker_after_deletion

Possible fix: #1811

/test pull-knative-sandbox-eventing-kafka-broker-reconciler-tests

@aliok
Copy link
Member Author

aliok commented Feb 1, 2022

Possible fix: #1811

If this PR merges w/o that fix, let's merge.

@aliok
Copy link
Member Author

aliok commented Feb 1, 2022

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

@knative-prow-robot knative-prow-robot merged commit d54b064 into knative-extensions:main Feb 1, 2022
@aliok aliok deleted the 2022-01-28-proper-e2e-testing-for-channel branch February 1, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants