Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] Handle host headers in dataplane for identification of channel instances #2036

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1990

- :gift: Handle host headers in dataplane for identification of channel instances

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@knative-prow
Copy link

knative-prow bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-1.3@c73da6a). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.3    #2036   +/-   ##
==============================================
  Coverage               ?   67.28%           
  Complexity             ?      640           
==============================================
  Files                  ?      141           
  Lines                  ?     6712           
  Branches               ?      187           
==============================================
  Hits                   ?     4516           
  Misses                 ?     1820           
  Partials               ?      376           
Flag Coverage Δ
java-unittests 81.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73da6a...12b6483. Read the comment docs.

@pierDipi
Copy link
Member

/retest

@pierDipi
Copy link
Member

/test unit-tests_eventing-kafka-broker_release-1.3

@knative-prow knative-prow bot merged commit 485cedf into knative-extensions:release-1.3 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants