-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the patch #3039
Update the patch #3039
Conversation
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #3039 +/- ##
=============================================
- Coverage 81.10% 64.21% -16.90%
Complexity 754 754
=============================================
Files 77 156 +79
Lines 2625 11034 +8409
Branches 232 232
=============================================
+ Hits 2129 7085 +4956
- Misses 361 3437 +3076
- Partials 135 512 +377
Flags with carried forward coverage won't be shown. Click here to find out more. see 79 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/assign @pierDipi |
/retest |
1 similar comment
/retest |
/hold |
seems not really needed after the bump we did in #3041 |
Looks like this is not needed anymore, and we can always revisit this, if really needed /close |
@matzew: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Proposed Changes
E.g. see here:
https://github.com/knative/eventing/actions/runs/4673652391/jobs/8277105585