Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the patch #3039

Closed

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Apr 12, 2023

Proposed Changes

  • Update a patch since applying fails

E.g. see here:
https://github.com/knative/eventing/actions/runs/4673652391/jobs/8277105585

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow
Copy link

knative-prow bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #3039 (0cb19c6) into main (920b29a) will decrease coverage by 16.90%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #3039       +/-   ##
=============================================
- Coverage     81.10%   64.21%   -16.90%     
  Complexity      754      754               
=============================================
  Files            77      156       +79     
  Lines          2625    11034     +8409     
  Branches        232      232               
=============================================
+ Hits           2129     7085     +4956     
- Misses          361     3437     +3076     
- Partials        135      512      +377     
Flag Coverage Δ
java-unittests 81.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 79 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matzew
Copy link
Contributor Author

matzew commented Apr 12, 2023

/assign @pierDipi

@matzew
Copy link
Contributor Author

matzew commented Apr 12, 2023

/retest

1 similar comment
@matzew
Copy link
Contributor Author

matzew commented Apr 12, 2023

/retest

@matzew
Copy link
Contributor Author

matzew commented Apr 14, 2023

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2023
@matzew
Copy link
Contributor Author

matzew commented Apr 19, 2023

seems not really needed after the bump we did in #3041

@matzew
Copy link
Contributor Author

matzew commented Apr 20, 2023

Looks like this is not needed anymore, and we can always revisit this, if really needed

/close

@knative-prow knative-prow bot closed this Apr 20, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 20, 2023

@matzew: Closed this PR.

In response to this:

Looks like this is not needed anymore, and we can always revisit this, if really needed

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants