Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry offset commit #3103

Merged
merged 1 commit into from
May 26, 2023
Merged

Retry offset commit #3103

merged 1 commit into from
May 26, 2023

Conversation

pierDipi
Copy link
Member

Before this patch, we were caching the new offset before committing to Kafka the offset, causing the offset to not be stored until a new record is successfully processed.

@pierDipi
Retry offset commit
f46ac52 
Before this patch, we were caching the new offset before committing
to Kafka the offset, causing the offset to not be stored until
a new record is successfully processed.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added area/data-plane approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2023
@pierDipi
Copy link
Member Author

/cc @maschmid @matzew

@knative-prow knative-prow bot requested review from maschmid and matzew May 25, 2023 16:26
@codecov
Copy link

codecov bot commented May 25, 2023 •
edited
Loading

Codecov Report

Merging #3103 (f46ac52) into main (7499c49) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #3103      +/-   ##
============================================
- Coverage     63.38%   63.36%   -0.03%     
- Complexity      757      758       +1     
============================================
  Files           167      167              
  Lines         11353    11354       +1     
  Branches        232      233       +1     
============================================
- Hits           7196     7194       -2     
- Misses         3633     3635       +2     
- Partials        524      525       +1
Flag Coverage Δ
java-unittests 81.01% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...broker/dispatcher/impl/consumer/OffsetManager.java 96.84% <100.00%> (+2.16%) ⬆️

... and 2 files with indirect coverage changes

matzew
matzew approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@knative-prow
Copy link

knative-prow bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 78727d7 into knative-extensions:main May 26, 2023
30 of 32 checks passed
@pierDipi pierDipi deleted the retry-offset-commit branch May 26, 2023 06:48
@pierDipi
Copy link
Member Author

/cherry-pick release-1.10

@pierDipi
Copy link
Member Author

/cherry-pick release-1.9

@knative-prow-robot knative-prow-robot mentioned this pull request May 26, 2023
Merged
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #3104

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request May 26, 2023
Merged
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #3105

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matzew pushed a commit to matzew/eventing-kafka-broker that referenced this pull request May 26, 2023
@pierDipi @matzew
Retry offset commit (knative-extensions#3103)
27d3437 
Before this patch, we were caching the new offset before committing
to Kafka the offset, causing the offset to not be stored until
a new record is successfully processed.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi mentioned this pull request May 29, 2023
Closed
openshift-merge-robot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request May 29, 2023
@matzew @pierDipi
Retry offset commit (knative-extensions#3103) (#703)
86fab21 
Before this patch, we were caching the new offset before committing
to Kafka the offset, causing the offset to not be stored until
a new record is successfully processed.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@maschmid maschmid Awaiting requested review from maschmid

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierDipi @knative-prow-robot @matzew