Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding modules that will have the Vert.x implementations of the kafka communication #3106

Merged
merged 5 commits into from
May 31, 2023
Merged

Adding modules that will have the Vert.x implementations of the kafka communication #3106

merged 5 commits into from
May 31, 2023

Conversation

debasishbsws
Copy link
Member

Module setup for #2928

Proposed Changes

  • empty modules Receiver-vertx & Producer-vertx added.

debasishbsws added 2 commits May 26, 2023 17:21
adding modules
26ee895 
Signed-off-by: debasishbsws <debasishbsws.abc@gmail.com>
adding copy right text to pom
6711f5e 
Signed-off-by: debasishbsws <debasishbsws.abc@gmail.com>
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2023
@knative-prow
Copy link

knative-prow bot commented May 26, 2023

Hi @debasishbsws. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented May 26, 2023 •
edited

Codecov Report

Merging #3106 (7aae1d0) into main (78727d7) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3106      +/-   ##
============================================
- Coverage     63.42%   63.34%   -0.08%     
  Complexity      758      758              
============================================
  Files           167      167              
  Lines         11354    11356       +2     
  Branches        233      233              
============================================
- Hits           7201     7194       -7     
- Misses         3626     3637      +11     
+ Partials        527      525       -2
Flag Coverage Δ
java-unittests 81.01% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@pierDipi
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2023
debasishbsws added 2 commits May 29, 2023 23:41
no jdk19 for vertx module & package name change
a565182 
Signed-off-by: debasishbsws <debasishbsws.abc@gmail.com>
added licence header
7095b2f 
Signed-off-by: debasishbsws <debasishbsws.abc@gmail.com>
@debasishbsws debasishbsws marked this pull request as ready for review May 29, 2023 19:05
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2023
pierDipi
pierDipi reviewed May 30, 2023
View reviewed changes
data-plane/pom.xml Outdated Show resolved Hide resolved
remove enable-priview from dataplane pom
7aae1d0 
Signed-off-by: debasishbsws <debasishbsws.abc@gmail.com>
pierDipi
pierDipi approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @debasishbsws

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@knative-prow
Copy link

knative-prow bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debasishbsws, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@pierDipi
Copy link
Member

/test channel-reconciler-tests-sasl-plain

@knative-prow knative-prow bot merged commit 5ab4757 into knative-extensions:main May 31, 2023
32 checks passed
@debasishbsws debasishbsws deleted the vertx-modules branch May 31, 2023 10:41
@creydr creydr mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@debasishbsws @pierDipi