Cherry pick sourcev2 upgrade fix to 1.9 #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nging (knative-extensions#3113) * Added empty FinalizeKind definition to prevent delete sources from hanging * Updated tests to handle reintroduction of finalizer patch events
knative-prow
bot
added
area/control-plane
size/L
|
/cc @pierDipi |
Codecov Report
@@ Coverage Diff @@
## release-1.9 #3115 +/- ##
==================================================
+ Coverage 58.84% 81.26% +22.41%
- Complexity 0 755 +755
==================================================
Files 79 77 -2
Lines 8374 2626 -5748
Branches 0 233 +233
==================================================
- Hits 4928 2134 -2794
+ Misses 3071 357 -2714
+ Partials 375 135 -240
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test upgrade-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow
bot
merged commit d735bab
into
knative-extensions:release-1.9
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes