ReactiveKafkaConsumer Interface and it's Vert.x Implementation

[debasishbsws]

Progress on #2928

Proposed Changes

• Identifies all the Consumer functions used and needs to be implemented in specialised modules.
• Implement all of these methods in the dispatcher vertx module with vertx implementation.

It may require some additional changes while migrating the base dispatcher to use ReactiveKafkaConsumer

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Merging #3159 (68efcf0) into main (6abfaa2) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 68efcf0 differs from pull request most recent head cfef090. Consider uploading reports for the commit cfef090 to get more accurate results

@@             Coverage Diff              @@
##               main    #3159      +/-   ##
============================================
- Coverage     63.57%   63.43%   -0.14%     
- Complexity      757      758       +1     
============================================
  Files           167      167              
  Lines         11518    11548      +30     
  Branches        233      239       +6     
============================================
+ Hits           7323     7326       +3     
- Misses         3656     3678      +22     
- Partials        539      544       +5     

Flag	Coverage Δ
java-unittests	80.22% <ø> (-0.80%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

[debasishbsws]

/ok-to-test

[debasishbsws]

/retest-required

[debasishbsws]

I added commit(...) method that is used in https://github.com/knative-sandbox/eventing-kafka-broker/blob/5a236cb645066be1fbb1d7ccbc95bfeac2b43ccd/data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/consumer/OffsetManager.java#L163-L165
But in apache kafkaConsumer it does not have commit(...), it has commitSync() and commitAsync()

Which method signature should I use for our Interface?

[pierDipi]

I added commit(...) method that is used in

https://github.com/knative-sandbox/eventing-kafka-broker/blob/5a236cb645066be1fbb1d7ccbc95bfeac2b43ccd/data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/consumer/OffsetManager.java#L163-L165

But in apache kafkaConsumer it does not have commit(...), it has commitSync() and commitAsync()
Which method signature should I use for our Interface?

I think the one you have used is good

[pierDipi]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debasishbsws, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment