-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate current dispatcher to use ReactiveKafkaConsumer
instead of Vertx KafkaConsumer.
#3177
Migrate current dispatcher to use ReactiveKafkaConsumer
instead of Vertx KafkaConsumer.
#3177
Conversation
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## main #3177 +/- ##
============================================
- Coverage 63.44% 63.41% -0.04%
+ Complexity 757 753 -4
============================================
Files 167 167
Lines 11756 11791 +35
Branches 239 238 -1
============================================
+ Hits 7459 7477 +18
- Misses 3736 3753 +17
Partials 561 561
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@pierDipi In the last commit basically I create |
Didn't look into the Benchmark module properly just migrate it to use Vertx implementation. |
/test all |
/retest-required |
I am not sure why the |
Tests are saying to run But we need that method as we call it from |
...java/dev/knative/eventing/kafka/broker/dispatcher/impl/consumer/OrderedConsumerVerticle.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debasishbsws, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4dd4f24
into
knative-extensions:main
progress #2928
The new dispatcher-vertx module is the one that uses Vertx implementation.
Proposed Changes
main()
tostart(..)
and call from the other module with specialised Consumer implementation as args.Aditional Info
ConsumerRebalanceListener
has gotten complex. I will simplify that further in the future.