Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use of KafkaProducer from the dispatcher and use ReactiveKafkaProducer instead #3206

Merged
merged 9 commits into from
Jul 13, 2023
Merged

Remove the use of KafkaProducer from the dispatcher and use ReactiveKafkaProducer instead #3206

merged 9 commits into from
Jul 13, 2023

Conversation

debasishbsws
Copy link
Member

Fixes #3191 and progress in #2928

Proposed Changes

A clean, without-conflict clone PR of #3192

@knative-prow
Copy link

knative-prow bot commented Jul 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/data-plane labels Jul 11, 2023
@debasishbsws debasishbsws mentioned this pull request Jul 11, 2023
Closed
@debasishbsws
Copy link
Member Author

/test all

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited

Codecov Report

Merging #3206 (7b05f36) into main (9590d86) will increase coverage by 0.05%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main    #3206      +/-   ##
============================================
+ Coverage     63.41%   63.47%   +0.05%     
- Complexity      747      762      +15     
============================================
  Files           167      169       +2     
  Lines         11815    11859      +44     
  Branches        246      246              
============================================
+ Hits           7493     7527      +34     
- Misses         3749     3759      +10     
  Partials        573      573
Flag Coverage Δ
java-unittests 79.66% <80.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ve/eventing/kafka/broker/dispatchervertx/Main.java 0.00% <0.00%> (ø)
...a/broker/dispatchervertx/VertxConsumerFactory.java 100.00% <ø> (ø)
...fka/broker/dispatchervertx/VertxKafkaConsumer.java 74.41% <ø> (ø)
...a/broker/dispatcher/impl/RecordDispatcherImpl.java 90.35% <ø> (ø)
...dispatcher/impl/ResponseToHttpEndpointHandler.java 100.00% <ø> (ø)
...ker/dispatcher/impl/consumer/ConsumerVerticle.java 93.10% <ø> (+6.89%) ⬆️
...broker/dispatcher/impl/consumer/OffsetManager.java 95.65% <ø> (ø)
...roker/dispatcher/main/ConsumerVerticleContext.java 93.33% <ø> (ø)
...ve/eventing/kafka/broker/dispatcher/main/Main.java 0.00% <ø> (ø)
...venting/kafka/broker/receiver/IngressProducer.java 100.00% <ø> (ø)
... and 6 more

... and 2 files with indirect coverage changes

@debasishbsws debasishbsws marked this pull request as ready for review July 11, 2023 16:46
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@debasishbsws
Copy link
Member Author

/retest

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@debasishbsws
Copy link
Member Author

/retest

1 similar comment
@debasishbsws
Copy link
Member Author

/retest

pierDipi
pierDipi approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debasishbsws, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@knative-prow knative-prow bot merged commit aa18175 into knative-extensions:main Jul 13, 2023
29 of 32 checks passed
@debasishbsws debasishbsws deleted the ReactiveProducer-in-dispatcher branch July 13, 2023 15:28
Rahul-Kumar-prog pushed a commit to Rahul-Kumar-prog/eventing-kafka-broker that referenced this pull request Jul 31, 2023
@Rahul-Kumar-prog
Remove the use of KafkaProducer from the dispatcher and use `Reacti…
5ea6713 
…veKafkaProducer` instead (knative-extensions#3206)

* Move Reactive Inteefaces into core module

* chenge ReactiveProducerFact to use in dispatche

* remove vertx KafkaProducer from dispatcher

* test module use vertx impl

* spotless formating and codegen

* Use ReceiverMock instead create new in dispatcher

* Remove unnesessury THIRD-PARTY file change

* remove not used constructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The base dispatcher module still use vertx.kafka.client lib
3 participants
@debasishbsws @pierDipi @knative-prow-robot