Consumer tracer to replace the use of Vert.x Kafka lib in base dispatcher module. #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## main #3269 +/- ##
============================================
- Coverage 61.89% 61.67% -0.22%
- Complexity 765 767 +2
============================================
Files 181 182 +1
Lines 12200 12249 +49
Branches 268 268
============================================
+ Hits 7551 7555 +4
- Misses 4061 4106 +45
Partials 588 588
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: debasishbsws <debasishbsws.abc@gmail.com> Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
Signed-off-by: debasishbsws <debasishbsws.abc@gmail.com> Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
Signed-off-by: debasishbsws <debasishbsws.abc@gmail.com> Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
Signed-off-by: debasishbsws <debasishbsws.abc@gmail.com> Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
Signed-off-by: debasishbsws <debasishbsws.abc@gmail.com> Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
debasishbsws
force-pushed
the
consumer-tracer
branch
from
7c95306
to
31b59c6
Compare
|
/retest-required |
|
/test channel-integration-tests-ssl |
matzew
reviewed
Aug 14, 2023
...main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/filter/ExactFilterBenchmark.java
Outdated
Show resolved
Hide resolved
matzew
reviewed
Aug 14, 2023
...src/main/java/dev/knative/eventing/kafka/broker/dispatcher/main/ConsumerVerticleBuilder.java
Show resolved
Hide resolved
Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
matzew
reviewed
Aug 14, 2023
.../core/src/main/java/dev/knative/eventing/kafka/broker/core/tracing/kafka/ConsumerTracer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
|
/test build-tests |
knative-prow
bot
added
lgtm
Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debasishbsws, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test channel-integration-tests-sasl-plain |
|
/retest |
|
/retest-required |
|
/test channel-integration-tests-ssl |
|
/retest |
1 similar comment
|
/retest |
knative-prow
bot
merged commit 21c92e7
into
knative-extensions:main
41 of 47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress #2928
Proposed Changes
finalExactFilterBenchmarkandFilterBenchmarkvia spotless. that might have been missed in the last PR Created abstract FilterBenchmark class #3247