Fixing: NullPointerException occurring and it's discarding the records while tracing for Loom deployment

[debasishbsws]

Problem

Current Loom Dispatcher was not working properly and there is no events retrieving on that side.

The Problem we find is that when we are using loom modules the ConsumerTracer (which is using vertx opentelemetry), is a NullPointerException occurring and it's discarding the records.

"stack_trace":"java.lang.NullPointerException": 
Cannot invoke "io.vertx.core.Context.getLocal(Object)" because "vertxCtx" is null
   at io.vertx.tracing.opentelemetry.VertxContextStorageProvider$VertxContextStorage.attach(VertxContextStorageProvider.java:27)
   at io.vertx.tracing.opentelemetry.OpenTelemetryTracer.receiveRequest(OpenTelemetryTracer.java:70)
   at io.vertx.tracing.opentelemetry.OpenTelemetryTracer.receiveRequest(OpenTelemetryTracer.java:31)
   at dev.knative.eventing.kafka.broker.core.tracing.kafka.ConsumerTracer.prepareMessageReceived(ConsumerTracer.java:88)
   at dev.knative.eventing.kafka.broker.dispatcher.impl.RecordDispatcherImpl.getStartedSpan(RecordDispatcherImpl.java:485)

Proposed Changes

As for the Solution we have here is we handle the records inside the current Vertx Context. So that when for the tracing we try to get the currentContext we get the context instead of null

eventing-kafka-broker/data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/RecordDispatcherImpl.java

Lines 203 to 205 in c6e8f3c

	// This needs to be done manually in order to work properly with both ordered and unordered delivery.
	Context context = Vertx.currentContext();
	final ConsumerTracer.StartedSpan span = getStartedSpan(recordContext, context);

/cc @pierDipi @matzew

Release Note

[Cali0707]

/cc @Cali0707

[codecov]

Codecov Report

Merging #3300 (3b92a3b) into main (c6e8f3c) will decrease coverage by 0.01%.
The diff coverage is 44.44%.

@@             Coverage Diff              @@
##               main    #3300      +/-   ##
============================================
- Coverage     61.69%   61.68%   -0.01%     
- Complexity      767      768       +1     
============================================
  Files           182      182              
  Lines         12298    12304       +6     
  Branches        268      268              
============================================
+ Hits           7587     7590       +3     
- Misses         4118     4120       +2     
- Partials        593      594       +1     

Flag	Coverage Δ
java-unittests	70.96% <44.44%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...patcher/impl/consumer/OrderedConsumerVerticle.java	67.27% <44.44%> (+0.91%)	⬆️
...tcher/impl/consumer/UnorderedConsumerVerticle.java	67.92% <44.44%> (-4.08%)	⬇️

[Cali0707]

@debasishbsws

/home/prow/go/src/knative.dev/eventing-kafka-broker is out of date. Please run hack/update-codegen.sh

[matzew]

/lgtm
/approve

/retest

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debasishbsws, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment