Set consumer and consumergroups finalizers when creating them

[pierDipi]

This is a mitigation for knative/pkg#2828

Before this patch, it was possible that a deleted consumer or
consumergroup might be reconciled and never finalized when
they are deleted before the finalizer is set.

This happens because the Knative generated reconciler uses
patch (as opposed to using update) for setting the finalizer
and patch doesn't have any optimistic concurrency controls.

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

Proposed Changes

• Set consumer and consumergroups finalizers when creating them

Release Note

Before this patch, it was possible that a deleted consumer or 
consumergroup might be reconciled and never finalized when
they are deleted before the finalizer is set.

This happens because the Knative generated reconciler uses
patch (as opposed to using update) for setting the finalizer
and patch doesn't have any optimistic concurrency controls.

[codecov]

Codecov Report

Merging #3355 (5e5e8a6) into main (e7f53ae) will decrease coverage by 3.09%.
Report is 8 commits behind head on main.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #3355      +/-   ##
============================================
- Coverage     61.61%   58.53%   -3.09%     
============================================
  Files           182       91      -91     
  Lines         12331     9237    -3094     
  Branches        268        0     -268     
============================================
- Hits           7598     5407    -2191     
+ Misses         4136     3402     -734     
+ Partials        597      428     -169     

Flag	Coverage Δ
java-unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
control-plane/pkg/reconciler/source/source.go	88.38% <100.00%> (+0.22%)	⬆️
...ls/kafka/eventing/v1alpha1/consumer_group_types.go	26.78% <0.00%> (-0.49%)	⬇️

... and 92 files with indirect coverage changes

[Cali0707]

@pierDipi is this related to knative/pkg#2828?

[pierDipi]

yes, it's a mitigation of it

/retest

[pierDipi]

/cc @matzew

[Cali0707]

/retest

[pierDipi]

/retest-required

[Cali0707]

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Cali0707]

/hold for other reviewers (if needed @pierDipi )

[pierDipi]

/unhold

[matzew]

/test channel-integration-tests-ssl

[creydr]

/retest-required

[matzew]

/retest

[knative-prow]

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
reconciler-tests-keda_eventing-kafka-broker_main	5e5e8a6	link	false	/test reconciler-tests-keda
reconciler-tests-loom_eventing-kafka-broker_main	5e5e8a6	link	false	/test reconciler-tests-loom
reconciler-tests-namespaced-broker-loom_eventing-kafka-broker_main	5e5e8a6	link	false	/test reconciler-tests-namespaced-broker-loom

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pierDipi]

/retest-required