Updated eventing to have new filters in beta #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/XXL
|
/cc @pierDipi |
|
/hold |
knative-prow
bot
added
the
do-not-merge/hold
Codecov Report
@@ Coverage Diff @@
## main #3366 +/- ##
============================================
+ Coverage 61.52% 70.88% +9.35%
Complexity 762 762
============================================
Files 181 90 -91
Lines 12314 3077 -9237
Branches 265 265
============================================
- Hits 7576 2181 -5395
+ Misses 4142 730 -3412
+ Partials 596 166 -430
Flags with carried forward coverage won't be shown. Click here to find out more. |
…s so that the update would fetch latest changes Signed-off-by: Calum Murray <cmurray@redhat.com>
Cali0707
force-pushed
the
dependency-bump
branch
from
7fee649
to
7bcf383
Compare
knative-prow
bot
added
lgtm
|
@Cali0707 you need to re-run |
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
area/control-plane
and removed
lgtm
|
/cc @pierDipi |
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
|
/test reconciler-tests |
pierDipi
reviewed
Oct 3, 2023
Signed-off-by: Calum Murray <cmurray@redhat.com>
pierDipi
reviewed
Oct 4, 2023
| @@ -129,6 +129,7 @@ func namespacedTriggerReconciliation(t *testing.T, format string, env config.Env | |||
| withTriggerSubscriberResolvedSucceeded(contract.DeliveryOrder_UNORDERED), | |||
| withTriggerStatusGroupIdAnnotation(TriggerUUID), | |||
| reconcilertesting.WithTriggerDeadLetterSinkNotConfigured(), | |||
| reconcilertesting.WithTriggerOIDCIdentityCreatedSucceededBecauseOIDCFeatureDisabled(), | |||
There was a problem hiding this comment.
I just realized how long this function name is
|
/approve |
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
pierDipi
reviewed
Oct 4, 2023
| @@ -129,7 +129,7 @@ func namespacedTriggerReconciliation(t *testing.T, format string, env config.Env | |||
| withTriggerSubscriberResolvedSucceeded(contract.DeliveryOrder_UNORDERED), | |||
| withTriggerStatusGroupIdAnnotation(TriggerUUID), | |||
| reconcilertesting.WithTriggerDeadLetterSinkNotConfigured(), | |||
| reconcilertesting.WithTriggerOIDCIdentityCreatedSucceededBecauseOIDCFeatureDisabled(), | |||
| reconcilertesting.WithTriggerOIDCIdentityCreatedNotSupported(), | |||
There was a problem hiding this comment.
We don't need this call, it's done in reconcilertesting.WithInitTriggerConditions
pierDipi
reviewed
Oct 4, 2023
| @@ -87,6 +87,7 @@ type Reconciler struct { | |||
| } | |||
|
|
|||
| func (r *Reconciler) ReconcileKind(ctx context.Context, trigger *eventing.Trigger) reconciler.Event { | |||
| trigger.Status.MarkOIDCIdentityCreatedNotSupported() | |||
There was a problem hiding this comment.
Do we have an issue tracking this?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Calum Murray <cmurray@redhat.com>
|
/lgtm |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
|
/retest-required |
1 similar comment
|
/retest-required |
knative-prow
bot
merged commit 9d3559a
into
knative-extensions:main
34 of 36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3363
Proposed Changes
Release Note
Docs