E2E tests for sink: TLS key pair rotation #3395

Leo6Leo · 2023-10-12T19:17:07Z

Fixes #3375

Proposed Changes

Add the rekt test for keypair rotation for kafka sink

Bugs Found

TLS port 8443 is not exposed for https-container
In the control-plane/config/eventing-kafka-broker/100-sink/100-kafka-sink.yaml, there is no custom resource definition for the addressable

Backporting

Upstream
Midstream

Release Note

TLS port 8443 is not exposed for sink https-container (#3395)

In the control-plane/config/eventing-kafka-broker/100-sink/100-kafka-sink.yaml, there is no custom resource definition for the addressable (#3395)

knative-prow · 2023-10-12T19:17:09Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov · 2023-10-12T19:23:53Z

Codecov Report

Merging #3395 (c614e98) into main (204be08) will decrease coverage by 3.09%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #3395      +/-   ##
============================================
- Coverage     61.46%   58.37%   -3.09%     
============================================
  Files           181       91      -90     
  Lines         12356     9285    -3071     
  Branches        265        0     -265     
============================================
- Hits           7594     5420    -2174     
+ Misses         4161     3431     -730     
+ Partials        601      434     -167

Flag	Coverage Δ
java-unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
control-plane/pkg/reconciler/sink/controller.go	`69.47% <100.00%> (+2.05%)`	⬆️

... and 90 files with indirect coverage changes

Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

test/rekt/features/sink_tls.go

Leo6Leo · 2023-10-13T17:23:48Z

/retest-required

Leo6Leo · 2023-10-16T18:20:23Z

/retest-required

Leo6Leo · 2023-10-18T05:39:39Z

/retest-required

Leo6Leo · 2023-10-18T13:44:16Z

/retest-required

pierDipi

/lgtm
/approve

pierDipi

/lgtm
/approve

knative-prow · 2023-10-18T14:04:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Leo6Leo · 2023-10-18T15:09:52Z

/retest-required

pierDipi · 2023-10-18T15:58:10Z

/test channel-integration-tests-ssl

Leo6Leo · 2023-10-18T18:01:45Z

/retest-required

Leo6Leo · 2023-10-18T21:53:31Z

/cherry-pick release-1.11

knative-prow-robot · 2023-10-18T21:54:16Z

@Leo6Leo: #3395 failed to apply on top of branch "release-1.11":

Applying: Exposing the 8443 port for https
Applying: Add the test implementation
Applying: Fix the custom resource definition
Applying: Fix the custom resource definition
Applying: Go formt and imports
Applying: Adding the configmap watcher feature store
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/sink/controller.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane/pkg/reconciler/sink/controller.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/sink/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0006 Adding the configmap watcher feature store
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Cali0707 · 2023-10-19T14:00:02Z

@Leo6Leo can you cherry pick this manually to release-1.11?

Leo6Leo · 2023-10-19T14:18:41Z

@Cali0707 There are some issues when merging the broker TLS keypair rotation tickets. @pierDipi mentioned that he has a PR to be merged, and after that the problem will be resolved. Then I will be manually cherry-pick on this PR just to not dealing with the merging conflicts.

* Exposing the 8443 port for https * Add the test implementation * Fix the custom resource definition Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix the custom resource definition Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Go formt and imports * Adding the configmap watcher feature store * Formatting issue --------- Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

…#925) * Using the composite prober for the sink (knative-extensions#3267) * E2E tests for sink: TLS key pair rotation (knative-extensions#3395) * Exposing the 8443 port for https * Add the test implementation * Fix the custom resource definition Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix the custom resource definition Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Go formt and imports * Adding the configmap watcher feature store * Formatting issue --------- Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Co-authored-by: Rahul kumar <68837569+Rahul-Kumar-prog@users.noreply.github.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

…3510) * Using the composite prober for the sink (#3267) * E2E tests for sink: TLS key pair rotation (#3395) * Exposing the 8443 port for https * Add the test implementation * Fix the custom resource definition Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix the custom resource definition Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Go formt and imports * Adding the configmap watcher feature store * Formatting issue --------- Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Co-authored-by: Rahul kumar <68837569+Rahul-Kumar-prog@users.noreply.github.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Leo6Leo added 2 commits October 12, 2023 11:45

Exposing the 8443 port for https

03f9983

Add the test implementation

6dd935a

knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023

knative-prow bot requested a review from odacremolbap October 12, 2023 19:17

knative-prow bot added the area/control-plane label Oct 12, 2023

knative-prow bot requested a review from pierDipi October 12, 2023 19:17

knative-prow bot added area/data-plane area/test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2023

Leo6Leo changed the title ~~E2E tests for sink: TLS key pair rotation~~ [WIP] E2E tests for sink: TLS key pair rotation Oct 12, 2023

Leo6Leo and others added 2 commits October 13, 2023 09:51

Fix the custom resource definition

52e76e4

Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Fix the custom resource definition

a14cc41

Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Leo6Leo marked this pull request as ready for review October 13, 2023 13:52

Leo6Leo changed the title ~~[WIP] E2E tests for sink: TLS key pair rotation~~ E2E tests for sink: TLS key pair rotation Oct 13, 2023

knative-prow bot requested review from Cali0707 and creydr October 13, 2023 13:52

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2023

Go formt and imports

314705a

pierDipi reviewed Oct 13, 2023

View reviewed changes

test/rekt/features/sink_tls.go Outdated Show resolved Hide resolved

Leo6Leo closed this Oct 13, 2023

Leo6Leo reopened this Oct 13, 2023

Leo6Leo changed the title ~~E2E tests for sink: TLS key pair rotation~~ [WIP] E2E tests for sink: TLS key pair rotation Oct 16, 2023

knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2023

Leo6Leo added 2 commits October 17, 2023 16:38

Adding the configmap watcher feature store

f4d3462

Merge branch 'main' into sink-keypair-rotation

5074e46

Leo6Leo force-pushed the sink-keypair-rotation branch from e225eaa to 5074e46 Compare October 17, 2023 20:41

Formatting issue

c614e98

Leo6Leo requested a review from pierDipi October 18, 2023 05:50

Leo6Leo changed the title ~~[WIP] E2E tests for sink: TLS key pair rotation~~ E2E tests for sink: TLS key pair rotation Oct 18, 2023

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023

pierDipi approved these changes Oct 18, 2023

View reviewed changes

knative-prow bot assigned pierDipi Oct 18, 2023

knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2023

pierDipi approved these changes Oct 18, 2023

View reviewed changes

knative-prow bot merged commit 660893a into knative-extensions:main Oct 18, 2023
32 of 36 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

E2E tests for sink: TLS key pair rotation #3395

E2E tests for sink: TLS key pair rotation #3395

Leo6Leo commented Oct 12, 2023 •

edited

knative-prow bot commented Oct 12, 2023

codecov bot commented Oct 12, 2023 •

edited

Leo6Leo commented Oct 13, 2023

Leo6Leo commented Oct 16, 2023

Leo6Leo commented Oct 18, 2023

Leo6Leo commented Oct 18, 2023

pierDipi left a comment

pierDipi left a comment

knative-prow bot commented Oct 18, 2023

Leo6Leo commented Oct 18, 2023

pierDipi commented Oct 18, 2023

Leo6Leo commented Oct 18, 2023

Leo6Leo commented Oct 18, 2023

knative-prow-robot commented Oct 18, 2023

Cali0707 commented Oct 19, 2023

Leo6Leo commented Oct 19, 2023

E2E tests for sink: TLS key pair rotation #3395

E2E tests for sink: TLS key pair rotation #3395

Conversation

Leo6Leo commented Oct 12, 2023 • edited

Proposed Changes

Bugs Found

Backporting

knative-prow bot commented Oct 12, 2023

codecov bot commented Oct 12, 2023 • edited

Codecov Report

Leo6Leo commented Oct 13, 2023

Leo6Leo commented Oct 16, 2023

Leo6Leo commented Oct 18, 2023

Leo6Leo commented Oct 18, 2023

pierDipi left a comment

Choose a reason for hiding this comment

pierDipi left a comment

Choose a reason for hiding this comment

knative-prow bot commented Oct 18, 2023

Leo6Leo commented Oct 18, 2023

pierDipi commented Oct 18, 2023

Leo6Leo commented Oct 18, 2023

Leo6Leo commented Oct 18, 2023

knative-prow-robot commented Oct 18, 2023

Cali0707 commented Oct 19, 2023

Leo6Leo commented Oct 19, 2023

Leo6Leo commented Oct 12, 2023 •

edited

codecov bot commented Oct 12, 2023 •

edited