Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sped up benchmarks #3401

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

Cali0707
Copy link
Member

Fixes #3320

Proposed Changes

  • Only benchmark throughput rather than all modes
  • Reduce the number of warmup trials and their runtimes
  • Reduce the number of measurement trials
  • (bonus: small bugfix to the existing benchmarks for all filter and any filter)

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2023
@Cali0707
Copy link
Member Author

/cc @pierDipi @Leo6Leo @matzew

@knative-prow knative-prow bot requested a review from aliok October 16, 2023 15:52
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #3401 (7527ece) into main (515c043) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3401      +/-   ##
============================================
- Coverage     61.48%   61.46%   -0.02%     
- Complexity      761      762       +1     
============================================
  Files           181      181              
  Lines         12356    12356              
  Branches        265      265              
============================================
- Hits           7597     7595       -2     
- Misses         4159     4161       +2     
  Partials        600      600              
Flag Coverage Δ
java-unittests 70.88% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@Cali0707
Copy link
Member Author

/test channel-integration-tests-sasl-plain

@Cali0707
Copy link
Member Author

/retest-required

@knative-prow knative-prow bot merged commit 4168215 into knative-extensions:main Oct 17, 2023
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Event Filtering: Speed up Java Benchmarks
2 participants