Dispatcher authenticate requests #3677

creydr · 2024-02-07T10:16:44Z

Proposed Changes

🎁 Add OIDC token to requests, when target (subscriber/reply/DLS) has an audience set

Release Note

Authenticate requests in case target has an OIDC audience set

codecov · 2024-02-07T10:21:29Z

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (3655d6d) 62.03% compared to head (2df48e9) 62.06%.

Files	Patch %	Lines
...eventing/kafka/broker/core/oidc/TokenProvider.java	8.00%	23 Missing ⚠️
...roker/dispatcher/main/ConsumerVerticleBuilder.java	33.33%	6 Missing ⚠️
...ispatcher/impl/http/WebClientCloudEventSender.java	83.33%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3677      +/-   ##
============================================
+ Coverage     62.03%   62.06%   +0.03%     
- Complexity      858      859       +1     
============================================
  Files           189      189              
  Lines         12831    12857      +26     
  Branches        275      275              
============================================
+ Hits           7960     7980      +20     
- Misses         4243     4245       +2     
- Partials        628      632       +4

Flag	Coverage Δ
java-unittests	`74.59% <43.10%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

creydr · 2024-02-07T21:30:13Z

/retest-required

creydr · 2024-02-08T08:49:41Z

Added an e2e test in f7f2ced. Anyhow should wait until #3675 is in, as we setup the OIDC test env there.

/hold

creydr · 2024-02-08T10:24:17Z

/retest-required

creydr · 2024-02-08T11:43:30Z

/test reconciler-tests-namespaced-broker

creydr · 2024-02-08T13:03:24Z

/test reconciler-tests-namespaced-broker

creydr · 2024-02-08T15:01:37Z

Rebased.

as #3675 merged:
/hold cancel

creydr · 2024-02-08T15:46:17Z

/test channel-reconciler-tests-ssl

creydr · 2024-02-08T15:47:53Z

e2e test for the channel passes:

PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Prerequisite/transport_encryption_is_strict (0.01s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Prerequisite/should_not_run_when_Istio_is_enabled (0.01s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Prerequisite/OIDC_authentication_is_enabled (0.01s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Prerequisite (0.00s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Setup/install_subscription (5.57s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Setup/install_channel (5.57s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Setup/channel_is_ready (6.53s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Setup/subscription_is_ready (9.53s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Setup/install_sink (19.35s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Setup (0.00s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Requirement/install_source (4.71s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Requirement (0.00s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Assert/channel_dispatcher_authenticate_requests_with_OIDC (6.00s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Assert (0.00s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC/Teardown (0.00s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC/Channel_dispatcher_authenticates_requests_with_OIDC (30.08s)
PASS test/e2e_new_channel.TestKafkaChannelDispatcherAuthenticatesWithOIDC (42.45s)

creydr · 2024-02-08T15:50:16Z

Hey @pierDipi @Cali0707 @Leo6Leo,
this PR is also ready for review. Could you check on it?
Thanks a lot in advance

creydr · 2024-02-08T16:14:07Z

/test reconciler-tests

creydr · 2024-02-08T17:20:27Z

/test reconciler-tests

creydr · 2024-02-08T17:25:33Z

/cc @Cali0707 @Leo6Leo @pierDipi

Cali0707

/lgtm
/approve

knative-prow · 2024-02-08T19:46:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Cali0707,creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Change TokenProvider to return future to get a token * Dispatcher add OIDC to token, when target has an audience set * Add e2e test

* Update contract with fields for OIDC information (knative-extensions#3632) * Update contract to include OIDC information * Run hack/update-codegen.sh * Move OIDC SA to egress * Expose OIDC audience of KafkaChannel in its status (knative-extensions#3622) * Provision .status.address.audience and .status.addresses[*].audience in KafkaChannel * Add kafka Channel e2e test to check if audience is provisioned * Run goimport * Update deps * Auto generate Triggers OIDC identity service account and expose in its status (knative-extensions#3604) * Support auto generation of Triggers identity service account and expose in AuthStatus Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * fix unit test Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * make ServiceAccountLister public Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * add oidc unit test Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * fix unit test Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * integrate oidc unit test Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * add some logic to reconcile triggers, if the features config map gets updated Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * fix unit test Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * revert vendor/knative.dev/pkg/webhook/resourcesemantics/defaulting/controller.go Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * fix unit test Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * fix Verify Deps and Codegen test Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * fix unit test and reconcile triggers, in case of the features configmap changes Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> --------- Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> * Create KafkaSources OIDC service account and expose in its status (knative-extensions#3660) * Create KafkaSources OIDC service account and expose in its status * Run goimport * Provision contract with OIDC information (knative-extensions#3646) * Provision contract with OIDC information * Add DLS audience in KafkaChannel CRD * Update KafkaSource to expose its sinks audience in status * Update Trigger test to include OIDC SA in contract * Propagate KafkaSources OIDC serviceAccountName to consumer and consumergroup * Propagate triggerv2s serviceAccountName to consumergroup * Fix unit test * [data-plane] Add the caching for OIDC JWT token to tokenprovider (knative-extensions#3663) * Add the caching to tokenprovider * Add the boiler * Running the codegen * Running the codegen * Revert "Running the codegen" This reverts commit 0ccf69c. * Use constant, set buffer before token expire, remove unnecessary change * Codegen changes * Codegen changes * Update data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/oidc/TokenProvider.java Co-authored-by: Christoph Stäbler <cstabler@redhat.com> * Fix the review comments * Run codegen * Codegen changes * Code gen again --------- Co-authored-by: Christoph Stäbler <cstabler@redhat.com> * Receiver reject requests for wrong audience (knative-extensions#3675) * Receiver: reject request for wrong audience * Switch to AuthenticationHandler * Fix "Request has already been read" issue * Change TokenVerifier to an interface * Initialize TokenVerifier in main * Add test for AuthenticationHandler * Only initialize OIDC discovery config in main and create a TokenVerifier per verticle instance. * Rerun hack/update-codegen.sh * Move TokenVerifier setup into setup() to prevent null pointer exception when vertx is null * Update KafkaChannel OIDC e2e tests, to run OIDC conformance tests so the receiver is tested too. * Run OIDC e2e tests as part of the reconciler suite * Fix KafkaChannelOIDC e2e test * Fix lint issue * Address review comments * Dispatcher authenticate requests (knative-extensions#3677) * Change TokenProvider to return future to get a token * Dispatcher add OIDC to token, when target has an audience set * Add e2e test * Support exposing the Audience of a Broker (knative-extensions#3600) * Support exposing the Audience of a Broker * fix formatting * fix formatting * test fixes * Populate broker.status.addresses[*].audience field too * Run goimports and gofmt * Fix unit test --------- Co-authored-by: Christoph Stäbler <cstabler@redhat.com> * Add broker OIDC e2e tests (knative-extensions#3685) * Add broker OIDC e2e tests * Fix broker template to allow TLS & OIDC configuration on dead letter sink * Remove unneeded check when setting broker audience (knative-extensions#3708) * Check status code of OIDC discovery response (knative-extensions#3707) * Check status code of OIDC discovery endpoint * Run update-codegen.sh * Only allow 200 status code on OIDC discovery endpoint * Run update-deps.sh * Add OIDC tests to encryption/auth test suite * run make generate-release * TokenVerifier: execute blocking calls in parallel (knative-extensions#3728) * TokenVerifier: execute blocking calls in parallel * Revert "TokenVerifier: execute blocking calls in parallel" This reverts commit f3dbde9. * Revert: removed changes in contract.pb.go * Cancel receiver pod start on invalid OIDC config only if authentication.oidc is enabled (knative-extensions#3761) * Cancel pod start on invalid OIDC config only if authentication.oidc is enabled * Update namespaced broker to copy features configmap too. * Add unit test for FeaturesConfig class (knative-extensions#3771) * Add unit test for FeaturesConfig class * Update data-plane/core/src/test/java/dev/knative/eventing/kafka/broker/core/features/FeaturesConfigTest.java Co-authored-by: Calum Murray <cmurray@redhat.com> --------- Co-authored-by: Calum Murray <cmurray@redhat.com> * Run make generate-release again --------- Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> Co-authored-by: cola <45722758+xiangpingjiang@users.noreply.github.com> Co-authored-by: Leo Li <leoli@redhat.com> Co-authored-by: Gunish Matta <33680363+gunishmatta@users.noreply.github.com> Co-authored-by: Partha Ghosh <112557191+parth721@users.noreply.github.com> Co-authored-by: Calum Murray <cmurray@redhat.com>

knative-prow bot requested review from aliok and lionelvillard February 7, 2024 10:16

creydr force-pushed the dispatcher-authenticate-requests branch from 8ef8f69 to 5a739b3 Compare February 7, 2024 21:37

knative-prow bot added the area/control-plane label Feb 7, 2024

creydr force-pushed the dispatcher-authenticate-requests branch from 5a739b3 to f7f2ced Compare February 8, 2024 08:48

knative-prow bot added the area/test label Feb 8, 2024

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024

creydr changed the title ~~[WIP] Dispatcher authenticate requests~~ Dispatcher authenticate requests Feb 8, 2024

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024

creydr added 3 commits February 8, 2024 15:59

Change TokenProvider to return future to get a token

d9fce49

Dispatcher add OIDC to token, when target has an audience set

0225b01

Add e2e test

2df48e9

creydr force-pushed the dispatcher-authenticate-requests branch from f7f2ced to 2df48e9 Compare February 8, 2024 15:00

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024

knative-prow bot requested review from Cali0707, Leo6Leo and pierDipi February 8, 2024 17:25

Cali0707 approved these changes Feb 8, 2024

View reviewed changes

knative-prow bot assigned Cali0707 Feb 8, 2024

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024

knative-prow bot merged commit 5c92833 into knative-extensions:main Feb 8, 2024
36 of 37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dispatcher authenticate requests #3677

Dispatcher authenticate requests #3677

creydr commented Feb 7, 2024

codecov bot commented Feb 7, 2024 •

edited

creydr commented Feb 7, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

Cali0707 left a comment

knative-prow bot commented Feb 8, 2024

Dispatcher authenticate requests #3677

Dispatcher authenticate requests #3677

Conversation

creydr commented Feb 7, 2024

Proposed Changes

codecov bot commented Feb 7, 2024 • edited

Codecov Report

creydr commented Feb 7, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

creydr commented Feb 8, 2024

Cali0707 left a comment

Choose a reason for hiding this comment

knative-prow bot commented Feb 8, 2024

codecov bot commented Feb 7, 2024 •

edited