Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] Bump CloudEvents GO-SDK to 2.15.2 #3740

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Mar 7, 2024

Proposed Changes

  • lastest of Go-Sdk

Release Note

Using 2.15.2 of Go-sdk for CloudEvents

Docs

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Copy link

knative-prow bot commented Mar 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2024
@knative-prow knative-prow bot requested review from aliok and pierDipi March 7, 2024 16:15
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2024
@matzew matzew marked this pull request as ready for review March 7, 2024 16:15
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2024
@knative-prow knative-prow bot requested a review from Cali0707 March 7, 2024 16:15
@matzew
Copy link
Contributor Author

matzew commented Mar 7, 2024

/cherry-pick release-1.12

@knative-prow-robot
Copy link
Contributor

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
Copy link

knative-prow bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.46%. Comparing base (b11073f) to head (386b39e).

Additional details and impacted files
@@                Coverage Diff                 @@
##             release-1.13    #3740      +/-   ##
==================================================
- Coverage           57.93%   52.46%   -5.47%     
- Complexity              0      845     +845     
==================================================
  Files                  91      338     +247     
  Lines                9418    20742   +11324     
  Branches                0      273     +273     
==================================================
+ Hits                 5456    10883    +5427     
- Misses               3517     8980    +5463     
- Partials              445      879     +434     
Flag Coverage Δ
java-unittests 74.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Contributor Author

matzew commented Mar 7, 2024

/test unit-tests

@matzew
Copy link
Contributor Author

matzew commented Mar 7, 2024

/test channel-reconciler-tests-ssl

@knative-prow knative-prow bot merged commit 0da6205 into knative-extensions:release-1.13 Mar 7, 2024
36 of 37 checks passed
@knative-prow-robot
Copy link
Contributor

@matzew: new pull request created: #3741

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matzew added a commit to matzew/eventing-kafka-broker that referenced this pull request Mar 12, 2024
…3740)

* 💫 Bump to latest of GO SDK for CE

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 🤖 Running ./hack/update-deps.sh && ./hack/update-codegen.sh scripts

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
openshift-merge-bot bot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Mar 13, 2024
…3740) (#1016)

* 💫 Bump to latest of GO SDK for CE



* 🤖 Running ./hack/update-deps.sh && ./hack/update-codegen.sh scripts



---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants