-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.13] Use error log level when contract parsing fails #3744
[release-1.13] Use error log level when contract parsing fails #3744
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.13 #3744 +/- ##
==================================================
+ Coverage 48.46% 52.47% +4.01%
- Complexity 0 846 +846
==================================================
Files 241 338 +97
Lines 17535 20742 +3207
Branches 0 273 +273
==================================================
+ Hits 8498 10884 +2386
- Misses 8326 8980 +654
- Partials 711 878 +167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test reconciler-tests-namespaced-broker |
ca09ace
into
knative-extensions:release-1.13
This is an automated cherry-pick of #3738